feat: update tests

app/models/form/sales/pages/living_before_purchase.rb

@@ -3,6 +3,7 @@ class Form::Sales::Pages::LivingBeforePurchase < ::Form::Page
     super(id, hsh, subsection)
     @ownershipsch = ownershipsch
   end
+
   def questions
     @questions ||= [
       living_before_purchase,

app/models/form/sales/questions/mortgage_amount.rb

@@ -24,4 +24,3 @@ class Form::Sales::Questions::MortgageAmount < ::Form::Question
     end
   end
 end
-

spec/helpers/question_view_helper_spec.rb

@@ -44,7 +44,13 @@ RSpec.describe QuestionViewHelper do
   describe "legend" do
     subject(:question_view_helper) { legend(question, page_header, conditional) }
 
-    let(:question) { OpenStruct.new(header: "Some question header") }
+    question_stub = Struct.new(:header) do
+      def question_number_string(_conditional)
+        nil
+      end
+    end
+
+    let(:question) { question_stub.new("Some question header") }
     let(:size) { "m" }
     let(:tag) { "div" }
     let(:legend_options_hash) do
@@ -67,7 +73,7 @@ RSpec.describe QuestionViewHelper do
       end
     end
 
-    context "when viewinng a conditional question" do
+    context "when viewing a conditional question" do
       let(:conditional) { true }
       let(:tag) { "" }
 

spec/models/form/sales/pages/about_deposit_without_discount_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::AboutDepositWithoutDiscount, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { nil }
   let(:page_definition) { nil }

spec/models/form/sales/pages/extra_borrowing_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::ExtraBorrowing, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { nil }
   let(:page_definition) { nil }

spec/models/form/sales/pages/leasehold_charges_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::LeaseholdCharges, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { nil }
   let(:page_definition) { nil }

spec/models/form/sales/pages/living_before_purchase_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::LivingBeforePurchase, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { nil }
   let(:page_definition) { nil }

spec/models/form/sales/pages/mortgage_amount_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::MortgageAmount, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { nil }
   let(:page_definition) { nil }

spec/models/form/sales/pages/mortgage_lender_other_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::MortgageLenderOther, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { "mortgage_lender_other" }
   let(:page_definition) { nil }

spec/models/form/sales/pages/mortgage_lender_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::MortgageLender, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { "mortgage_lender" }
   let(:page_definition) { nil }

spec/models/form/sales/pages/mortgage_length_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::MortgageLength, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { nil }
   let(:page_definition) { nil }

spec/models/form/sales/pages/mortgageused_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::Mortgageused, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { "mortgage_used" }
   let(:page_definition) { nil }

spec/models/form/sales/pages/purchase_price_outright_ownership_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Pages::PurchasePriceOutrightOwnership, type: :model do
-  subject(:page) { described_class.new(page_id, page_definition, subsection) }
+  subject(:page) { described_class.new(page_id, page_definition, subsection, ownershipsch: 1) }
 
   let(:page_id) { "purchase_price" }
   let(:page_definition) { nil }

spec/models/form/sales/questions/buyer1_income_known_spec.rb

@@ -20,7 +20,7 @@ RSpec.describe Form::Sales::Questions::Buyer1IncomeKnown, type: :model do
   end
 
   it "has the correct check_answer_label" do
-    expect(question.check_answer_label).to eq("Buyer 1’s gross annual income")
+    expect(question.check_answer_label).to eq("Buyer 1’s gross annual income known?")
   end
 
   it "has the correct type" do

spec/models/form/sales/questions/buyer2_income_known_spec.rb

@@ -20,7 +20,7 @@ RSpec.describe Form::Sales::Questions::Buyer2IncomeKnown, type: :model do
   end
 
   it "has the correct check_answer_label" do
-    expect(question.check_answer_label).to eq("Buyer 2’s gross annual income")
+    expect(question.check_answer_label).to eq("Buyer 2’s gross annual income known?")
   end
 
   it "has the correct type" do

spec/models/form/sales/questions/deposit_amount_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::DepositAmount, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/extra_borrowing_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::ExtraBorrowing, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/grant_spec.rb

@@ -32,7 +32,7 @@ RSpec.describe Form::Sales::Questions::Grant, type: :model do
   end
 
   it "has the correct hint" do
-    expect(question.hint_text).to eq("For all schemes except Right to Buy (RTB), Preserved Right to Buy (PRTB), Voluntary Right to Buy (VRTB)")
+    expect(question.hint_text).to eq("For all schemes except Right to Buy (RTB), Preserved Right to Buy (PRTB), Voluntary Right to Buy (VRTB) and Rent to Buy")
   end
 
   it "has correct width" do

spec/models/form/sales/questions/leasehold_charges_known_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::LeaseholdChargesKnown, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/leasehold_charges_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::LeaseholdCharges, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/living_before_purchase_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::LivingBeforePurchase, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/living_before_purchase_years_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::LivingBeforePurchaseYears, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/mortgage_amount_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::MortgageAmount, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/mortgage_lender_other_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::MortgageLenderOther, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/mortgage_lender_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::MortgageLender, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/mortgage_length_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::MortgageLength, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/mortgageused_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::Mortgageused, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/questions/purchase_price_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Form::Sales::Questions::PurchasePrice, type: :model do
-  subject(:question) { described_class.new(question_id, question_definition, page) }
+  subject(:question) { described_class.new(question_id, question_definition, page, ownershipsch: 1) }
 
   let(:question_id) { nil }
   let(:question_definition) { nil }

spec/models/form/sales/subsections/discounted_ownership_scheme_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe Form::Sales::Subsections::DiscountedOwnershipScheme, type: :model
         extra_borrowing_price_value_check
         about_price_not_rtb
         grant_value_check
-        purchase_price_outright_ownership
+        purchase_price_discounted_ownership
         about_price_discounted_ownership_value_check
         discounted_ownership_deposit_and_mortgage_value_check_after_value_and_discount
         mortgage_used_discounted_ownership