diff --git a/app/services/csv/lettings_log_csv_service.rb b/app/services/csv/lettings_log_csv_service.rb index 6ce9fea35..4b9b5a834 100644 --- a/app/services/csv/lettings_log_csv_service.rb +++ b/app/services/csv/lettings_log_csv_service.rb @@ -183,11 +183,7 @@ module Csv end def get_label(value, attribute, log) - return LETTYPE_LABELS[value] if attribute == "lettype" - return IRPRODUCT_LABELS[value] if attribute == "irproduct" - return LAR_LABELS[value] if attribute == "lar" - return NEWPROP_LABELS[value] if attribute == "newprop" - return INCREF_LABELS[value] if attribute == "incref" + return LABELS[attribute][value] if LABELS.key?(attribute) return conventional_yes_no_label(value) if CONVENTIONAL_YES_NO_ATTRIBUTES.include?(attribute) return "Yes" if YES_OR_BLANK_ATTRIBUTES.include?(attribute) && value == 1 @@ -210,6 +206,14 @@ module Csv value == 1 ? "Yes" : nil end + LABELS = { + "lettype": LETTYPE_LABELS, + "irproduct": IRPRODUCT_LABELS, + "lar": LAR_LABELS, + "newprop": NEWPROP_LABELS, + "incref": INCREF_LABELS, + }.freeze + LETTYPE_LABELS = { 1 => "Social rent general needs private registered provider", 2 => "Social rent supported housing private registered provider",