feat: move logic from views/schemes/show into schemes_helper

app/helpers/schemes_helper.rb

@@ -18,7 +18,11 @@ module SchemesHelper
     ]
 
     if FeatureToggle.scheme_toggle_enabled?
-      base_attributes.append({ name: "Status", value: scheme.status })
+      base_attributes.append({ name: "Status", value: status_tag(scheme.status) })
+    end
+
+    if current_user.data_coordinator?
+      base_attributes.delete_if {|item| item[:name] == "Housing stock owned by"}
     end
 
     if scheme.arrangement_type_same?

app/views/schemes/show.html.erb

@@ -20,10 +20,9 @@
 
       <%= govuk_summary_list do |summary_list| %>
         <% display_scheme_attributes(@scheme).each do |attr| %>
-          <% next if current_user.data_coordinator? && attr[:name] == ("Housing stock owned by") %>
           <%= summary_list.row do |row| %>
-            <% row.key { attr[:name].eql?("Registered under Care Standards Act 2000") ? "Registered under Care Standards Act 2000" : attr[:name].to_s.humanize } %>
-            <% row.value { attr[:name].eql?("Status") ? status_tag(attr[:value]) : details_html(attr) } %>
+            <% row.key { attr[:name] } %>
+            <% row.value { details_html(attr) } %>
             <% row.action(text: "Change", href: scheme_edit_name_path(scheme_id: @scheme.id)) if attr[:edit] %>
           <% end %>
         <% end %>