From 51b6b75969341605bd516c61b11e1f9c984a4cd4 Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Thu, 1 Dec 2022 14:53:25 +0000 Subject: [PATCH] fix test - we now do a lookup for the expected start year on current form --- spec/requests/bulk_upload_lettings_logs_controller_spec.rb | 4 +++- spec/requests/bulk_upload_sales_logs_controller_spec.rb | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/spec/requests/bulk_upload_lettings_logs_controller_spec.rb b/spec/requests/bulk_upload_lettings_logs_controller_spec.rb index 788965e83..3b59d449d 100644 --- a/spec/requests/bulk_upload_lettings_logs_controller_spec.rb +++ b/spec/requests/bulk_upload_lettings_logs_controller_spec.rb @@ -10,11 +10,13 @@ RSpec.describe BulkUploadLettingsLogsController, type: :request do describe "GET /lettings-logs/bulk-upload-logs/start" do context "when not in crossover period" do + let(:expected_year) { FormHandler.instance.forms["current_lettings"].start_date.year } + it "redirects to /prepare-your-file" do Timecop.freeze(2022, 1, 1) do get "/lettings-logs/bulk-upload-logs/start", params: {} - expect(response).to redirect_to("/lettings-logs/bulk-upload-logs/prepare-your-file?form%5Byear%5D=2022") + expect(response).to redirect_to("/lettings-logs/bulk-upload-logs/prepare-your-file?form%5Byear%5D=#{expected_year}") end end end diff --git a/spec/requests/bulk_upload_sales_logs_controller_spec.rb b/spec/requests/bulk_upload_sales_logs_controller_spec.rb index f668b0da1..348179dd2 100644 --- a/spec/requests/bulk_upload_sales_logs_controller_spec.rb +++ b/spec/requests/bulk_upload_sales_logs_controller_spec.rb @@ -10,11 +10,13 @@ RSpec.describe BulkUploadSalesLogsController, type: :request do describe "GET /sales-logs/bulk-upload-logs/start" do context "when not in crossover period" do + let(:expected_year) { FormHandler.instance.forms["current_sales"].start_date.year } + it "redirects to /prepare-your-file" do Timecop.freeze(2022, 1, 1) do get "/sales-logs/bulk-upload-logs/start", params: {} - expect(response).to redirect_to("/sales-logs/bulk-upload-logs/prepare-your-file?form%5Byear%5D=2022") + expect(response).to redirect_to("/sales-logs/bulk-upload-logs/prepare-your-file?form%5Byear%5D=#{expected_year}") end end end