From 4bef27c957d076f40870f8dad87dfb763aaa77b0 Mon Sep 17 00:00:00 2001 From: oscar-richardson-softwire Date: Thu, 29 Jan 2026 16:30:54 +0000 Subject: [PATCH] Minor tweaks --- app/models/derived_variables/lettings_log_variables.rb | 2 +- spec/models/lettings_log_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/models/derived_variables/lettings_log_variables.rb b/app/models/derived_variables/lettings_log_variables.rb index 7fb818a25..1c7f161c1 100644 --- a/app/models/derived_variables/lettings_log_variables.rb +++ b/app/models/derived_variables/lettings_log_variables.rb @@ -86,7 +86,7 @@ module DerivedVariables::LettingsLogVariables end set_housingneeds_fields if housingneeds? - if form.start_year_2025_or_later? && is_general_needs? + if form.start_year_2026_or_later? || (form.start_year_2025_or_later? && is_general_needs?) if changed_to_newbuild? && uprn.nil? self.manual_address_entry_selected = true end diff --git a/spec/models/lettings_log_spec.rb b/spec/models/lettings_log_spec.rb index be6e82d32..baf2a40ed 100644 --- a/spec/models/lettings_log_spec.rb +++ b/spec/models/lettings_log_spec.rb @@ -670,11 +670,11 @@ RSpec.describe LettingsLog do location.update!(postcode: "AA1 1AA") Timecop.freeze(startdate) Singleton.__init__(FormHandler) - lettings_log.update_columns( # We can't call `.update!` as validations prevent this invalid state from being persisted. - startdate:, - postcode_full: "BB2 2BB", + lettings_log.update!( + startdate: ) lettings_log.reload + lettings_log.postcode_full = "BB2 2BB" end after do