From 485a732e2eca691a5758ee3e72f4a9b07ca37488 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Thu, 1 Aug 2024 16:10:42 +0100
Subject: [PATCH] Refactor IF

---
 app/services/imports/variable_definitions_service.rb | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/app/services/imports/variable_definitions_service.rb b/app/services/imports/variable_definitions_service.rb
index 0d12c08d1..79b509b68 100644
--- a/app/services/imports/variable_definitions_service.rb
+++ b/app/services/imports/variable_definitions_service.rb
@@ -35,11 +35,8 @@ module Imports
         next if variable.nil? || definition.nil?
 
         existing_record = CsvVariableDefinition.find_by(variable: variable.strip, definition: definition.strip, log_type:)
-        if existing_record
-          if user_type == "user" && existing_record.user_type == "support"
-            existing_record.update!(user_type: "user")
-          end
-        else
+
+        if existing_record.nil?
           CsvVariableDefinition.create!(
             variable: variable.strip,
             definition: definition.strip,
@@ -48,6 +45,8 @@ module Imports
             year:,
           )
           records_added += 1
+        elsif existing_record.user_type == "support" && user_type == "user"
+          existing_record.update!(user_type: "user")
         end
       end