From 483018be998edd1ba6f613845d7e10a1d1ac81e1 Mon Sep 17 00:00:00 2001
From: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
Date: Thu, 13 Jul 2023 13:50:17 +0100
Subject: [PATCH] Update flaky test (#1773)

---
 spec/requests/lettings_logs_controller_spec.rb | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/spec/requests/lettings_logs_controller_spec.rb b/spec/requests/lettings_logs_controller_spec.rb
index 2fc1ef461..bcf1210ce 100644
--- a/spec/requests/lettings_logs_controller_spec.rb
+++ b/spec/requests/lettings_logs_controller_spec.rb
@@ -469,13 +469,13 @@ RSpec.describe LettingsLogsController, type: :request do
               let(:bulk_upload) { create(:bulk_upload, :lettings, user:) }
 
               let!(:included_log) { create(:lettings_log, :in_progress, bulk_upload:, owning_organisation: organisation) }
-              let!(:excluded_log) { create(:lettings_log, :in_progress, owning_organisation: organisation) }
+              let!(:excluded_log) { create(:lettings_log, :in_progress, owning_organisation: organisation, tenancycode: "fake_code") }
 
               it "returns logs only associated with the bulk upload" do
                 get "/lettings-logs?bulk_upload_id[]=#{bulk_upload.id}"
 
                 expect(page).to have_content(included_log.id)
-                expect(page).not_to have_content(excluded_log.id)
+                expect(page).not_to have_content(excluded_log.tenancycode)
               end
 
               it "dislays how many logs remaining to fix" do
@@ -522,14 +522,16 @@ RSpec.describe LettingsLogsController, type: :request do
               let(:other_user) { create(:user, organisation:) }
               let(:bulk_upload) { create(:bulk_upload, :lettings, user: other_user) }
 
-              let!(:excluded_log) { create(:lettings_log, bulk_upload:, owning_organisation: organisation) }
-              let!(:also_excluded_log) { create(:lettings_log, owning_organisation: organisation) }
+              before do
+                create(:lettings_log, bulk_upload:, owning_organisation: organisation, tenancycode: "fake_code_1")
+                create(:lettings_log, owning_organisation: organisation, tenancycode: "fake_code_2")
+              end
 
               it "does not return any logs" do
                 get "/lettings-logs?bulk_upload_id[]=#{bulk_upload.id}"
 
-                expect(page).not_to have_content(excluded_log.id)
-                expect(page).not_to have_content(also_excluded_log.id)
+                expect(page).not_to have_content("fake_code_1")
+                expect(page).not_to have_content("fake_code_2")
               end
             end