From 44bd2363d1f85c30ecf50d739fa51f026b04fe0c Mon Sep 17 00:00:00 2001 From: Sam Seed Date: Mon, 24 Apr 2023 12:43:07 +0100 Subject: [PATCH] fix: add .presence to question.header and remove & before .downcase --- app/services/bulk_upload/lettings/year2023/row_parser.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 7605d8d9f..b40c58556 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -542,15 +542,15 @@ private if setup_question?(question) fields.each do |field| if errors[field].present? - question_text = question.check_answer_label.presence || question.header || "this question" - errors.add(field, I18n.t("validations.not_answered", question: question_text&.downcase), category: :setup) + question_text = question.check_answer_label.presence || question.header.presence || "this question" + errors.add(field, I18n.t("validations.not_answered", question: question_text.downcase), category: :setup) end end else fields.each do |field| unless errors.any? { |e| fields.include?(e.attribute) } - question_text = question.check_answer_label.presence || question.header || "this question" - errors.add(field, I18n.t("validations.not_answered", question: question_text&.downcase)) + question_text = question.check_answer_label.presence || question.header.presence || "this question" + errors.add(field, I18n.t("validations.not_answered", question: question_text.downcase)) end end end