From 4431725f61bac29cbf04f3392c78c3dca775b551 Mon Sep 17 00:00:00 2001
From: Jack S <jacopo.scotti@softwire.com>
Date: Fri, 13 Jan 2023 16:54:58 +0000
Subject: [PATCH] Add hard validation to cash deposit

---
 .../sales/sale_information_validations.rb     |  9 ++++
 .../sale_information_validations_spec.rb      | 49 +++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 app/models/validations/sales/sale_information_validations.rb
 create mode 100644 spec/models/validations/sales/sale_information_validations_spec.rb

diff --git a/app/models/validations/sales/sale_information_validations.rb b/app/models/validations/sales/sale_information_validations.rb
new file mode 100644
index 000000000..4c8747f18
--- /dev/null
+++ b/app/models/validations/sales/sale_information_validations.rb
@@ -0,0 +1,9 @@
+module Validations::Sales::SaleInformationValidations
+  def validate_deposit_range(record)
+    return if record.deposit.blank?
+
+    unless record.deposit >= 0 && record.deposit <= 999_999
+      record.errors.add :deposit, "Cash deposit must be £0 - £999,999"
+    end
+  end
+end
diff --git a/spec/models/validations/sales/sale_information_validations_spec.rb b/spec/models/validations/sales/sale_information_validations_spec.rb
new file mode 100644
index 000000000..575eedfff
--- /dev/null
+++ b/spec/models/validations/sales/sale_information_validations_spec.rb
@@ -0,0 +1,49 @@
+require "rails_helper"
+
+RSpec.describe Validations::Sales::SaleInformationValidations do
+  subject(:sale_information_validator) { validator_class.new }
+
+  let(:validator_class) { Class.new { include Validations::Sales::SaleInformationValidations } }
+
+  describe "#validate_deposit_range" do
+    context "when within permitted bounds" do
+      let(:record) { build(:sales_log, deposit: 0) }
+
+      it "does not add an error" do
+        sale_information_validator.validate_deposit_range(record)
+
+        expect(record.errors[:deposit]).not_to be_present
+      end
+    end
+
+    context "when blank" do
+      let(:record) { build(:sales_log, deposit: nil) }
+
+      it "does not add an error" do
+        sale_information_validator.validate_deposit_range(record)
+
+        expect(record.errors[:deposit]).not_to be_present
+      end
+    end
+
+    context "when below lower bound" do
+      let(:record) { build(:sales_log, deposit: -1) }
+
+      it "adds an error" do
+        sale_information_validator.validate_deposit_range(record)
+
+        expect(record.errors[:deposit]).to be_present
+      end
+    end
+
+    context "when higher than upper bound" do
+      let(:record) { build(:sales_log, deposit: 1_000_000) }
+
+      it "adds an error" do
+        sale_information_validator.validate_deposit_range(record)
+
+        expect(record.errors[:deposit]).to be_present
+      end
+    end
+  end
+end