From 42a6512845dda1f3712ff8fdbf2c1f228919dae4 Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Thu, 19 Jan 2023 12:43:27 +0000 Subject: [PATCH] fix incorrect logic for bulk upload renewal --- app/services/bulk_upload/lettings/row_parser.rb | 2 +- spec/services/bulk_upload/lettings/row_parser_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/services/bulk_upload/lettings/row_parser.rb b/app/services/bulk_upload/lettings/row_parser.rb index c59409144..b1985b71b 100644 --- a/app/services/bulk_upload/lettings/row_parser.rb +++ b/app/services/bulk_upload/lettings/row_parser.rb @@ -663,7 +663,7 @@ private when 2 0 when nil - field_116 == 14 ? 1 : 0 + rsnvac == 14 ? 1 : 0 end end diff --git a/spec/services/bulk_upload/lettings/row_parser_spec.rb b/spec/services/bulk_upload/lettings/row_parser_spec.rb index 66bdee6c5..3b83f737c 100644 --- a/spec/services/bulk_upload/lettings/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/row_parser_spec.rb @@ -373,8 +373,8 @@ RSpec.describe BulkUpload::Lettings::RowParser do end end - context "when field_134 is null but rsnvac/field_116 is 14" do - let(:attributes) { { bulk_upload:, field_134: "", field_116: "14" } } + context "when field_134 is null but rsnvac/field_106 is 14" do + let(:attributes) { { bulk_upload:, field_134: "", field_106: "14" } } it "sets renewal to 1" do expect(parser.log.renewal).to eq(1)