From 42665b016207bca2c800610c6488e16c0bea2606 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Mon, 11 Nov 2024 16:23:31 +0000
Subject: [PATCH] Reverse combining if statements

---
 app/models/validations/setup_validations.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/models/validations/setup_validations.rb b/app/models/validations/setup_validations.rb
index a4c0878d0..8d1884fc2 100644
--- a/app/models/validations/setup_validations.rb
+++ b/app/models/validations/setup_validations.rb
@@ -77,7 +77,9 @@ module Validations::SetupValidations
 
     if record.scheme.status == :incomplete
       record.errors.add :scheme_id, :incomplete, message: I18n.t("validations.lettings.setup.scheme.incomplete")
-    elsif record.scheme.locations.nil? || (record.scheme.locations.present? && record.scheme.locations.confirmed.none?)
+    end
+
+    if record.scheme.locations.nil? || (record.scheme.locations.present? && record.scheme.locations.confirmed.none?)
       record.errors.add :scheme_id, :no_completed_locations, message: I18n.t("validations.lettings.setup.scheme.no_completed_locations")
     end