feat: test fix wip

spec/factories/lettings_log.rb

@@ -3,7 +3,7 @@ FactoryBot.define do
     created_by { FactoryBot.create(:user) }
     owning_organisation { created_by.organisation }
     managing_organisation { created_by.organisation }
-    trait :about_completed do
+    trait :setup_completed do
       renewal { 0 }
       needstype { 1 }
       rent_type { 1 }

spec/features/form/tasklist_page_spec.rb

@@ -33,7 +33,7 @@ RSpec.describe "Task List" do
   let(:setup_completed_log) do
     FactoryBot.create(
       :lettings_log,
-      :about_completed,
+      :setup_completed,
       owning_organisation: user.organisation,
       managing_organisation: user.organisation,
       created_by: user,
@@ -69,7 +69,7 @@ RSpec.describe "Task List" do
 
   it "shows number of completed sections if one section is completed" do
     visit("/lettings-logs/#{setup_completed_log.id}")
-    expect(page).to have_content("1 of 8 sections completed.")
+    expect(page).to have_content("1 of 8 subsections completed.")
   end
 
   it "show skip link for next incomplete section" do

spec/features/lettings_log_spec.rb

@@ -95,7 +95,7 @@ RSpec.describe "Lettings Log Features" do
     end
 
     context "when visiting a subsection check answers page" do
-      let(:lettings_log) { FactoryBot.create(:lettings_log, :about_completed) }
+      let(:lettings_log) { FactoryBot.create(:lettings_log, :setup_completed) }
 
       it "has the correct breadcrumbs with the correct links" do
         visit lettings_log_setup_check_answers_path(lettings_log)

spec/models/validations/financial_validations_spec.rb

@@ -86,7 +86,7 @@ RSpec.describe Validations::FinancialValidations do
     end
 
     context "when outstanding rent or charges is yes" do
-      let(:record) { FactoryBot.create(:lettings_log, :about_completed, startdate: Time.zone.now) }
+      let(:record) { FactoryBot.create(:lettings_log, :setup_completed, startdate: Time.zone.now) }
 
       it "expects that a shortfall is provided" do
         record.hbrentshortfall = 1

spec/requests/form_controller_spec.rb

@@ -15,7 +15,7 @@ RSpec.describe FormController, type: :request do
   let(:setup_complete_lettings_log) do
     create(
       :lettings_log,
-      :about_completed,
+      :setup_completed,
       status: 1,
       created_by: user,
     )
@@ -203,7 +203,7 @@ RSpec.describe FormController, type: :request do
       context "with form pages" do
         context "when forms exist for multiple years" do
           let(:lettings_log_year_1) { create(:lettings_log, owning_organisation: organisation, created_by: user) }
-          let(:lettings_log_year_2) { create(:lettings_log, :about_completed, startdate: Time.zone.local(2022, 5, 1), owning_organisation: organisation, created_by: user) }
+          let(:lettings_log_year_2) { create(:lettings_log, :setup_completed, startdate: Time.zone.local(2022, 5, 1), owning_organisation: organisation, created_by: user) }
 
           before do
             Timecop.freeze(Time.zone.local(2021, 5, 1))