From 3eacbcb0d8abafbdbee059cd7e4778e56e2144bb Mon Sep 17 00:00:00 2001
From: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
Date: Fri, 5 Jan 2024 11:24:06 +0000
Subject: [PATCH] CLDC-2951 Display postcodes error on ownership type (#2111)

* Display postcodes error on ownership type

* Add error to uprn
---
 app/models/validations/sales/property_validations.rb      | 2 ++
 .../models/validations/sales/property_validations_spec.rb | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/app/models/validations/sales/property_validations.rb b/app/models/validations/sales/property_validations.rb
index b1bdb5b62..3a8f6a463 100644
--- a/app/models/validations/sales/property_validations.rb
+++ b/app/models/validations/sales/property_validations.rb
@@ -5,6 +5,8 @@ module Validations::Sales::PropertyValidations
     if record.discounted_ownership_sale? && record.ppostcode_full != record.postcode_full
       record.errors.add :postcode_full, I18n.t("validations.property.postcode.must_match_previous")
       record.errors.add :ppostcode_full, I18n.t("validations.property.postcode.must_match_previous")
+      record.errors.add :ownershipsch, I18n.t("validations.property.postcode.must_match_previous")
+      record.errors.add :uprn, I18n.t("validations.property.postcode.must_match_previous")
     end
   end
 
diff --git a/spec/models/validations/sales/property_validations_spec.rb b/spec/models/validations/sales/property_validations_spec.rb
index af65446fc..0152428d8 100644
--- a/spec/models/validations/sales/property_validations_spec.rb
+++ b/spec/models/validations/sales/property_validations_spec.rb
@@ -25,12 +25,16 @@ RSpec.describe Validations::Sales::PropertyValidations do
         record.postcode_full = "SW1A 1AA"
         property_validator.validate_postcodes_match_if_discounted_ownership(record)
         expect(record.errors["postcode_full"]).to be_empty
+        expect(record.errors["ppostcode_full"]).to be_empty
+        expect(record.errors["ownershipsch"]).to be_empty
       end
 
       it "when postcode_full is not present no error is added" do
         record.ppostcode_full = "SW1A 1AA"
         property_validator.validate_postcodes_match_if_discounted_ownership(record)
         expect(record.errors["postcode_full"]).to be_empty
+        expect(record.errors["ppostcode_full"]).to be_empty
+        expect(record.errors["ownershipsch"]).to be_empty
       end
 
       it "when postcodes match no error is added" do
@@ -38,6 +42,8 @@ RSpec.describe Validations::Sales::PropertyValidations do
         record.ppostcode_full = "SW1A 1AA"
         property_validator.validate_postcodes_match_if_discounted_ownership(record)
         expect(record.errors["postcode_full"]).to be_empty
+        expect(record.errors["ppostcode_full"]).to be_empty
+        expect(record.errors["ownershipsch"]).to be_empty
       end
 
       it "when postcodes do not match an error is added" do
@@ -45,6 +51,8 @@ RSpec.describe Validations::Sales::PropertyValidations do
         record.ppostcode_full = "SW1A 0AA"
         property_validator.validate_postcodes_match_if_discounted_ownership(record)
         expect(record.errors["postcode_full"]).to include(match I18n.t("validations.property.postcode.must_match_previous"))
+        expect(record.errors["ppostcode_full"]).to include(match I18n.t("validations.property.postcode.must_match_previous"))
+        expect(record.errors["ownershipsch"]).to include(match I18n.t("validations.property.postcode.must_match_previous"))
       end
     end
   end