diff --git a/app/models/form/lettings/pages/address_selection.rb b/app/models/form/lettings/pages/address_selection.rb index 4e7a8ec74..850680308 100644 --- a/app/models/form/lettings/pages/address_selection.rb +++ b/app/models/form/lettings/pages/address_selection.rb @@ -12,7 +12,7 @@ class Form::Lettings::Pages::AddressSelection < ::Form::Page end def routed_to?(log, _current_user = nil) - log.uprn_known == 0 && log.address_line1.present? && log.postcode_full.present? + log.uprn_known.zero? && log.address_line1.present? && log.postcode_full.present? end def skip_text @@ -21,6 +21,7 @@ class Form::Lettings::Pages::AddressSelection < ::Form::Page def skip_href(log = nil) return unless log + "/#{log.model_name.param_key.dasherize}s/#{log.id}/address-matcher" end end diff --git a/app/models/form/lettings/questions/address_selection.rb b/app/models/form/lettings/questions/address_selection.rb index 3f0f5e1c7..c28a69e99 100644 --- a/app/models/form/lettings/questions/address_selection.rb +++ b/app/models/form/lettings/questions/address_selection.rb @@ -8,7 +8,7 @@ class Form::Lettings::Questions::AddressSelection < ::Form::Question @disable_clearing_if_not_routed_or_dynamic_answer_options = true end - def answer_options(log = nil, user = nil) + def answer_options(log = nil, _user = nil) answer_opts = { "10" => { "value" => "The address is not listed" } } return answer_opts unless ActiveRecord::Base.connected? return answer_opts unless log diff --git a/app/services/address_client.rb b/app/services/address_client.rb index 7f270bfd1..9bc827f20 100644 --- a/app/services/address_client.rb +++ b/app/services/address_client.rb @@ -23,7 +23,7 @@ class AddressClient @result ||= JSON.parse(response.body)["results"]&.map { |address| address["DPA"] } end - private +private def http_client client = Net::HTTP.new(ADDRESS, 443)