fix some tests broken after rebasing

spec/factories/sales_log.rb

@@ -21,13 +21,13 @@ FactoryBot.define do
       saledate { Time.zone.today }
     end
     trait :shared_ownership_setup_complete do
-      saledate { Time.zone.today }
+      saledate_today
       ownershipsch { 1 }
       type { 30 }
       jointpur { 2 }
     end
     trait :outright_sale_setup_complete do
-      saledate { Time.zone.today }
+      saledate_today
       ownershipsch { 3 }
       type { 10 }
       companybuy { 2 }

spec/models/form/sales/questions/uprn_confirmation_spec.rb

@@ -50,7 +50,7 @@ RSpec.describe Form::Sales::Questions::UprnConfirmation, type: :model do
 
     context "when address is present" do
       it "returns formatted value" do
-        log = create(:sales_log, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234", uprn_known: 1)
+        log = build(:sales_log, :outright_sale_setup_complete, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234", uprn_known: 1)
 
         expect(question.notification_banner(log)).to eq(
           {

spec/models/sales_log_spec.rb

@@ -571,8 +571,8 @@ RSpec.describe SalesLog, type: :model do
       end
     end
 
-    context "when service errors" do
+    context "when the API returns an error" do
-      let(:sales_log) { create(:sales_log, uprn_known: 1, uprn: "123456789", uprn_confirmed: 1) }
+      let(:sales_log) { build(:sales_log, :outright_sale_setup_complete, uprn_known: 1, uprn: "123456789", uprn_confirmed: 1) }
       let(:error_message) { "error" }
 
       it "adds error to sales log" do