From 3b0efa52934456ae6cf52dd3bf5808dd643491f2 Mon Sep 17 00:00:00 2001
From: magicmilo <milobascombe@gmail.com>
Date: Thu, 4 Nov 2021 12:05:18 +0000
Subject: [PATCH] fixed broken test

---
 app/helpers/check_answers_helper.rb       | 6 ++++--
 spec/fixtures/forms/test_form.json        | 2 +-
 spec/helpers/check_answers_helper_spec.rb | 2 +-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/app/helpers/check_answers_helper.rb b/app/helpers/check_answers_helper.rb
index 37debfd8c..4cafe3731 100644
--- a/app/helpers/check_answers_helper.rb
+++ b/app/helpers/check_answers_helper.rb
@@ -14,8 +14,10 @@ module CheckAnswersHelper
     subsection_keys = form.pages_for_subsection(subsection).keys
     page_name = subsection_keys.first
 
+    # binding.pry
+
     while page_name.to_s != "check_answers" && subsection_keys.include?(page_name)
-      binding.pry
+      # binding.pry
       questions = form.questions_for_page(page_name)
       applicable_questions = filter_conditional_questions(questions, case_log)
       total_questions = total_questions.merge(applicable_questions)
@@ -53,7 +55,7 @@ module CheckAnswersHelper
   end
 
   def condition_not_met(case_log, question_key, question, condition)
-    binding.pry
+    # binding.pry
     case question["type"]
     when "numeric"
       operator = condition[/[<>=]+/].to_sym
diff --git a/spec/fixtures/forms/test_form.json b/spec/fixtures/forms/test_form.json
index 35590cb3e..ab1b69c76 100644
--- a/spec/fixtures/forms/test_form.json
+++ b/spec/fixtures/forms/test_form.json
@@ -497,7 +497,7 @@
                   "check_answer_label": "Postcode of previous accomodation if the household has moved from settled accommodation",
                   "header": "Postcode for the previous accommodation",
                   "hint_text": "If the household has moved from settled accommodation immediately prior to being re-housed",
-                  "type": "text",
+                  "type": "date",
                   "conditional_for": { "faake_key": "fake_condition" }
                 }
               }
diff --git a/spec/helpers/check_answers_helper_spec.rb b/spec/helpers/check_answers_helper_spec.rb
index 4d45c164d..38db2ef6b 100644
--- a/spec/helpers/check_answers_helper_spec.rb
+++ b/spec/helpers/check_answers_helper_spec.rb
@@ -104,7 +104,7 @@ RSpec.describe CheckAnswersHelper do
       end
 
       it "raises an error" do
-        allow_any_instance_of(Form).to receive(:pages_for_subsection).and_return(unimplemented_conditional)
+        allow_any_instance_of(Form).to receive(:questions_for_page).and_return(unimplemented_conditional)
         expect { total_number_of_questions(subsection, case_log, form) }.to raise_error(RuntimeError, "Not implemented yet")
       end
     end