diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 853b0dea9..9dc5b60de 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -624,9 +624,9 @@ private return if start_date.blank? || bulk_upload.form.blank? unless bulk_upload.form.valid_start_date_for_form?(start_date) - errors.add(:field_7, I18n.t("validations.date.outside_collection_window")) - errors.add(:field_8, I18n.t("validations.date.outside_collection_window")) - errors.add(:field_9, I18n.t("validations.date.outside_collection_window")) + errors.add(:field_7, I18n.t("validations.date.outside_collection_window"), category: :setup) + errors.add(:field_8, I18n.t("validations.date.outside_collection_window"), category: :setup) + errors.add(:field_9, I18n.t("validations.date.outside_collection_window"), category: :setup) end end diff --git a/app/services/bulk_upload/sales/year2022/row_parser.rb b/app/services/bulk_upload/sales/year2022/row_parser.rb index e53b42ecb..4383898fb 100644 --- a/app/services/bulk_upload/sales/year2022/row_parser.rb +++ b/app/services/bulk_upload/sales/year2022/row_parser.rb @@ -941,9 +941,9 @@ private return if saledate.blank? || bulk_upload.form.blank? unless bulk_upload.form.valid_start_date_for_form?(saledate) - errors.add(:field_2, I18n.t("validations.date.outside_collection_window")) - errors.add(:field_3, I18n.t("validations.date.outside_collection_window")) - errors.add(:field_4, I18n.t("validations.date.outside_collection_window")) + errors.add(:field_2, I18n.t("validations.date.outside_collection_window"), category: :setup) + errors.add(:field_3, I18n.t("validations.date.outside_collection_window"), category: :setup) + errors.add(:field_4, I18n.t("validations.date.outside_collection_window"), category: :setup) end end diff --git a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb index 06ebcbc25..ef9935b44 100644 --- a/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb @@ -717,8 +717,6 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do let(:attributes) { { bulk_upload:, field_5: "1", field_7: nil, field_8: nil, field_9: nil } } it "returns an error" do - parser.valid? - expect(parser.errors[:field_7]).to be_present expect(parser.errors[:field_8]).to be_present expect(parser.errors[:field_9]).to be_present @@ -729,8 +727,6 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do let(:attributes) { { bulk_upload:, field_9: "2022" } } it "returns an error" do - parser.valid? - expect(parser.errors[:field_9]).to include("Tenancy start year must be 2 digits") end end @@ -749,8 +745,6 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, year: 2022) } it "does not return errors" do - parser.valid? - expect(parser.errors[:field_7]).not_to be_present expect(parser.errors[:field_8]).not_to be_present expect(parser.errors[:field_9]).not_to be_present @@ -762,19 +756,16 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do Timecop.freeze(Date.new(2022, 4, 2)) do example.run end - Timecop.return end let(:attributes) { { bulk_upload:, field_7: "1", field_8: "1", field_9: "22" } } let(:bulk_upload) { create(:bulk_upload, :lettings, user:, year: 2022) } - it "returns errors" do - parser.valid? - - expect(parser.errors[:field_7]).to be_present - expect(parser.errors[:field_8]).to be_present - expect(parser.errors[:field_9]).to be_present + it "returns setup errors" do + expect(parser.errors.where(:field_7, category: :setup)).to be_present + expect(parser.errors.where(:field_8, category: :setup)).to be_present + expect(parser.errors.where(:field_9, category: :setup)).to be_present end end end diff --git a/spec/services/bulk_upload/sales/year2022/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2022/row_parser_spec.rb index 8c0a4cd45..7fdf8da4d 100644 --- a/spec/services/bulk_upload/sales/year2022/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2022/row_parser_spec.rb @@ -506,17 +506,16 @@ RSpec.describe BulkUpload::Sales::Year2022::RowParser do Timecop.freeze(Date.new(2022, 4, 2)) do example.run end - Timecop.return end let(:attributes) { setup_section_params.merge({ field_2: "1", field_3: "1", field_4: "22" }) } let(:bulk_upload) { create(:bulk_upload, :sales, user:, year: 2022) } - it "returns errors" do - expect(parser.errors[:field_2]).to be_present - expect(parser.errors[:field_3]).to be_present - expect(parser.errors[:field_4]).to be_present + it "returns setup errors" do + expect(parser.errors.where(:field_2, category: :setup)).to be_present + expect(parser.errors.where(:field_3, category: :setup)).to be_present + expect(parser.errors.where(:field_4, category: :setup)).to be_present end end end