From 362c6dd3590b9ca3a78da460e9a87eb7a01ab7df Mon Sep 17 00:00:00 2001 From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com> Date: Wed, 2 Oct 2024 08:40:20 +0100 Subject: [PATCH] Fix lint --- app/components/bulk_upload_summary_component.rb | 4 ++-- spec/models/bulk_upload_spec.rb | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/app/components/bulk_upload_summary_component.rb b/app/components/bulk_upload_summary_component.rb index ec5d6bd1a..c210f6463 100644 --- a/app/components/bulk_upload_summary_component.rb +++ b/app/components/bulk_upload_summary_component.rb @@ -57,9 +57,9 @@ class BulkUploadSummaryComponent < ViewComponent::Base path = if status == "important_errors" "summary_bulk_upload_#{bulk_upload.log_type}_result_url" - else + else "bulk_upload_#{bulk_upload.log_type}_result_path" - end + end link_to "View error report", send(path, bulk_upload), class: "govuk-link" end diff --git a/spec/models/bulk_upload_spec.rb b/spec/models/bulk_upload_spec.rb index 96ae2ab17..3f834695e 100644 --- a/spec/models/bulk_upload_spec.rb +++ b/spec/models/bulk_upload_spec.rb @@ -234,7 +234,10 @@ RSpec.describe BulkUpload, type: :model do context "when the bulk upload has visible logs, errors and is not complete" do let(:bulk_upload_errors) { create_list(:bulk_upload_error, 2, category: "soft_validation") } let(:bulk_upload) { create(:bulk_upload, :lettings, bulk_upload_errors:) } - let!(:log) { create(:lettings_log, :in_progress, bulk_upload:) } + + before do + create(:lettings_log, :in_progress, bulk_upload:) + end it "returns logs_uploaded_with_errors" do expect(bulk_upload.status).to eq(:logs_uploaded_with_errors) @@ -244,7 +247,10 @@ RSpec.describe BulkUpload, type: :model do context "when the bulk upload has visible logs, errors and is complete" do let(:bulk_upload_errors) { create_list(:bulk_upload_error, 2, category: "soft_validation") } let(:bulk_upload) { create(:bulk_upload, :lettings, bulk_upload_errors:) } - let!(:log) { create(:lettings_log, :completed, bulk_upload:) } + + before do + create(:lettings_log, :completed, bulk_upload:) + end it "returns errors_fixed_in_service" do expect(bulk_upload.status).to eq(:errors_fixed_in_service)