From 351faeb4d8f5bee11a81d00399aab948bcc77cd0 Mon Sep 17 00:00:00 2001 From: Sam Seed Date: Wed, 19 Apr 2023 16:48:28 +0100 Subject: [PATCH] chore: lint --- .../bulk_upload/lettings/year2023/csv_parser_spec.rb | 6 +++--- spec/support/bulk_upload/log_to_csv.rb | 4 +--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/spec/services/bulk_upload/lettings/year2023/csv_parser_spec.rb b/spec/services/bulk_upload/lettings/year2023/csv_parser_spec.rb index 24ca613bc..9559f96ed 100644 --- a/spec/services/bulk_upload/lettings/year2023/csv_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2023/csv_parser_spec.rb @@ -82,8 +82,8 @@ RSpec.describe BulkUpload::Lettings::Year2023::CsvParser do context "when parsing csv with extra invalid headers" do let(:seed) { rand } let(:log_to_csv) { BulkUpload::LogToCsv.new(log:) } - let(:field_numbers) { log_to_csv.default_2023_field_numbers + ["invalid_field_number"] } - let(:field_values) { log_to_csv.to_2023_row + ["value_for_invalid_field_number"] } + let(:field_numbers) { log_to_csv.default_2023_field_numbers + %w[invalid_field_number] } + let(:field_values) { log_to_csv.to_2023_row + %w[value_for_invalid_field_number] } before do file.write("Question\n") @@ -102,7 +102,7 @@ RSpec.describe BulkUpload::Lettings::Year2023::CsvParser do end it "counts the number of valid field numbers correctly" do - expect(service.valid_field_numbers_count).to eql(134) + expect(service.valid_field_numbers_count).to be(134) end end diff --git a/spec/support/bulk_upload/log_to_csv.rb b/spec/support/bulk_upload/log_to_csv.rb index 7355686e1..e754c7ee3 100644 --- a/spec/support/bulk_upload/log_to_csv.rb +++ b/spec/support/bulk_upload/log_to_csv.rb @@ -44,10 +44,8 @@ class BulkUpload::LogToCsv def to_custom_2023_csv_row(seed: nil, field_values: to_2023_row) if seed row = field_values.shuffle(random: Random.new(seed)) - (row_prefix + row).flatten.join(",") + line_ending - else - (row_prefix + row).flatten.join(",") + line_ending end + (row_prefix + row).flatten.join(",") + line_ending end def default_2023_field_numbers_row(seed: nil)