From 349fb942eb28501c36ecb0848da7260a57ab9569 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Tue, 17 Sep 2024 10:56:29 +0100
Subject: [PATCH] Sanitise all titles simpler

---
 app/helpers/application_helper.rb | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 52ff49ef7..10b045386 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -2,7 +2,7 @@ module ApplicationHelper
   include Pagy::Frontend
 
   def browser_title(title, pagy, *resources)
-    title = sanitise_characters(title)
+    title = CGI.unescapeHTML(title)
     if resources.any? { |r| r.present? && r.errors.present? }
       "Error: #{[title, t('service_name'), 'GOV.UK'].select(&:present?).join(' - ')}"
     else
@@ -31,13 +31,6 @@ module ApplicationHelper
   def notifications_to_display?
     !current_page?(notifications_path) && (authenticated_user_has_notifications? || unauthenticated_user_has_notifications?)
   end
-
-  def sanitise_characters(string)
-    return string unless string
-
-    CGI.unescapeHTML(string)
-  end
-
 private
 
   def paginated_title(title, pagy)