From 32ee42eb3e9bf5220ce94b41e2d9c3526829b5c6 Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Wed, 8 Mar 2023 17:27:06 +0000 Subject: [PATCH] ensure missing startdate is a setup error --- .../bulk_upload/lettings/row_parser_spec.rb | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/spec/services/bulk_upload/lettings/row_parser_spec.rb b/spec/services/bulk_upload/lettings/row_parser_spec.rb index 964efd0fb..68990c59b 100644 --- a/spec/services/bulk_upload/lettings/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/row_parser_spec.rb @@ -558,12 +558,12 @@ RSpec.describe BulkUpload::Lettings::RowParser do context "when all of these fields are blank" do let(:attributes) { { bulk_upload:, field_1: "1", field_96: nil, field_97: nil, field_98: nil } } - it "returns an error" do - parser.valid? + it "returns them as setup errors" do + setup_errors = parser.errors.select { |e| e.options[:category] == :setup } - expect(parser.errors[:field_96]).to be_present - expect(parser.errors[:field_97]).to be_present - expect(parser.errors[:field_98]).to be_present + expect(setup_errors.find { |e| e.attribute == :field_96 }).to be_present + expect(setup_errors.find { |e| e.attribute == :field_97 }).to be_present + expect(setup_errors.find { |e| e.attribute == :field_98 }).to be_present end end @@ -571,8 +571,6 @@ RSpec.describe BulkUpload::Lettings::RowParser do let(:attributes) { { bulk_upload:, field_1: "1", field_96: "1", field_97: "1", field_98: nil } } it "returns an error only on blank field" do - parser.valid? - expect(parser.errors[:field_96]).to be_blank expect(parser.errors[:field_97]).to be_blank expect(parser.errors[:field_98]).to be_present @@ -583,8 +581,6 @@ RSpec.describe BulkUpload::Lettings::RowParser do let(:attributes) { { bulk_upload:, field_98: "2022" } } it "returns an error" do - parser.valid? - expect(parser.errors[:field_98]).to include("Tenancy start year must be 2 digits") end end @@ -603,8 +599,6 @@ RSpec.describe BulkUpload::Lettings::RowParser do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, year: 2022) } it "does not return errors" do - parser.valid? - expect(parser.errors[:field_96]).not_to be_present expect(parser.errors[:field_97]).not_to be_present expect(parser.errors[:field_98]).not_to be_present @@ -623,8 +617,6 @@ RSpec.describe BulkUpload::Lettings::RowParser do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, year: 2022) } it "returns errors" do - parser.valid? - expect(parser.errors[:field_96]).to be_present expect(parser.errors[:field_97]).to be_present expect(parser.errors[:field_98]).to be_present