baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

CLDC-4402: form spec changes

CLDC-4402-audit-start-year-2024-or-later-usage
samyou-softwire 1 day ago
parent
acd763ada1
commit
328ba47ffa
1 changed files with 42 additions and 161 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 203
      spec/models/form_spec.rb

203
spec/models/form_spec.rb
Unescape View File

@ -1,26 +1,17 @@
require "rails_helper"
RSpec.describe Form, type: :model do
around do |example|
Timecop.freeze(Time.zone.local(2022, 1, 1)) do
Singleton.__init__(FormHandler)
example.run
end
Timecop.return
Singleton.__init__(FormHandler)
end
let(:user) { FactoryBot.build(:user) }
let(:lettings_log) { FactoryBot.build(:lettings_log, :in_progress) }
let(:form) { lettings_log.form }
let(:completed_lettings_log) { FactoryBot.build(:lettings_log, :completed) }
describe ".next_page" do
let(:previous_page_id) { form.get_page("person_1_age") }
let(:previous_page_id) { form.get_page("renewal") }
let(:value_check_previous_page) { form.get_page("net_income_value_check") }
it "returns the next page, given the previous" do
expect(form.next_page_id(previous_page_id, lettings_log, user)).to eq("person_1_gender")
expect(form.next_page_id(previous_page_id, lettings_log, user)).to eq("tenancy_start_date")
end
context "when the next page has more than one question" do
@ -68,170 +59,69 @@ RSpec.describe Form, type: :model do
it "returns the previous page if answer is `No` and the page is routed to" do
lettings_log.net_income_value_check = 1
expect(form.next_page_id(value_check_previous_page, lettings_log, user)).to eq("net_income")
expect(form.next_page_id(value_check_previous_page, lettings_log, user)).to eq(:check_answers)
end
it "returns the next page if answer is `Yes` answer and the page is routed to" do
lettings_log.net_income_value_check = 0
expect(form.next_page_id(value_check_previous_page, lettings_log, user)).to eq("net_income_uc_proportion")
expect(form.next_page_id(value_check_previous_page, lettings_log, user)).to eq(:check_answers)
end
end
end
describe ".previous_page" do
context "when the current page is not a value check page" do
let!(:subsection) { form.get_subsection("conditional_question") }
before do
lettings_log.preg_occ = 2
end
let!(:subsection) { form.get_subsection("setup") }
it "returns the previous page if the page is routed to" do
page = subsection.pages.find { |p| p.id == "conditional_question_no_second_page" }
expect(form.previous_page_id(page, lettings_log, user)).to eq("conditional_question_no_page")
page = form.get_page("rent_type")
expect(form.previous_page_id(page, lettings_log, user)).to eq("tenancy_start_date")
end
it "returns the page before the previous one if the previous page is not routed to" do
page = subsection.pages.find { |p| p.id == "conditional_question_no_page" }
expect(form.previous_page_id(page, lettings_log, user)).to eq("conditional_question")
lettings_log.needstype = 2
page = form.get_page("renewal")
expect(form.previous_page_id(page, lettings_log, user)).to eq("scheme")
end
end
end
describe "next_page_redirect_path" do
let(:previous_page_id) { form.get_page("net_income") }
let(:last_previous_page) { form.get_page("housing_benefit") }
let(:previous_conditional_page) { form.get_page("conditional_question") }
let(:previous_page_id) { form.get_page("renewal") }
let(:last_previous_page) { form.get_page("property_reference") }
let(:previous_conditional_page) { form.get_page("needs_type") }
it "returns a correct page path if there is no conditional routing" do
expect(form.next_page_redirect_path(previous_page_id, lettings_log, user)).to eq("lettings_log_net_income_uc_proportion_path")
expect(form.next_page_redirect_path(previous_page_id, lettings_log, user)).to eq("lettings_log_tenancy_start_date_path")
end
it "returns a check answers page if previous page is the last page" do
expect(form.next_page_redirect_path(last_previous_page, lettings_log, user)).to eq("lettings_log_income_and_benefits_check_answers_path")
expect(form.next_page_redirect_path(last_previous_page, lettings_log, user)).to eq("lettings_log_declaration_path")
end
it "returns a correct page path if there is conditional routing" do
lettings_log["preg_occ"] = 2
expect(form.next_page_redirect_path(previous_conditional_page, lettings_log, user)).to eq("lettings_log_conditional_question_no_page_path")
lettings_log.needstype = 2
expect(form.next_page_redirect_path(previous_conditional_page, lettings_log, user)).to eq("lettings_log_scheme_path")
end
end
describe "next_incomplete_section_redirect_path" do
let(:lettings_log) { FactoryBot.build_stubbed(:lettings_log, :in_progress) }
let(:subsection) { form.get_subsection("household_characteristics") }
let(:later_subsection) { form.get_subsection("declaration") }
let(:lettings_log) { FactoryBot.create(:lettings_log, :setup_completed) }
let(:subsection) { form.get_subsection("setup") }
let(:later_subsection) { form.get_subsection("income_and_benefits") }
context "when a user is on the check answers page for a subsection" do
def answer_household_needs(lettings_log)
lettings_log.armedforces = 3
lettings_log.illness = 0
lettings_log.housingneeds_a = 1
lettings_log.la = "E06000014"
lettings_log.illness_type_1 = 1
end
def answer_tenancy_information(lettings_log)
lettings_log.tenancycode = "1234"
end
def answer_property_information(lettings_log)
lettings_log.postcode_known = 1
lettings_log.wchair = "No"
end
def answer_conditional_question(lettings_log)
lettings_log.preg_occ = "No"
lettings_log.cbl = "No"
end
def answer_income_and_benefits(lettings_log)
lettings_log.earnings = 30_000
lettings_log.incfreq = 3
lettings_log.benefits = "Some"
lettings_log.hb = "Tenant prefers not to say"
end
def answer_rent_and_charges(lettings_log)
lettings_log.period = "Every 2 weeks"
lettings_log.brent = 650
lettings_log.scharge = 0
lettings_log.pscharge = 0
lettings_log.supcharg = 0
lettings_log.tcharge = 650
end
def answer_local_authority(lettings_log)
lettings_log.layear = "1 year but under 2 years"
lettings_log.waityear = "Less than 1 year"
lettings_log.postcode_full = "NW1 5TY"
lettings_log.reason = "Permanently decanted from another property owned by this landlord"
lettings_log.ppostcode_full = "SE2 6RT"
lettings_log.mrcdate = Time.zone.parse("03/11/2019")
end
before do
lettings_log.tenancycode = "123"
lettings_log.age1 = 35
lettings_log.sex1 = "M"
lettings_log.ecstat1 = 0
lettings_log.hhmemb = 2
lettings_log.relat2 = "P"
lettings_log.sex2 = "F"
lettings_log.ecstat2 = 1
lettings_log.needstype = 1
end
it "returns the first page of the next incomplete subsection if the subsection is not in progress" do
expect(form.next_incomplete_section_redirect_path(subsection, lettings_log)).to eq("armed-forces")
expect(form.next_incomplete_section_redirect_path(subsection, lettings_log)).to eq("first-time-property-let-as-social-housing")
end
it "returns the check answers page of the next incomplete subsection if the subsection is already in progress" do
lettings_log.armedforces = "No"
lettings_log.illness = "No"
expect(form.next_incomplete_section_redirect_path(subsection, lettings_log)).to eq("household-needs/check-answers")
end
it "returns the first page of the next incomplete subsection (skipping completed subsections, and pages that are not routed to)" do
answer_household_needs(lettings_log)
expect(form.next_incomplete_section_redirect_path(subsection, lettings_log)).to eq("property-postcode")
end
it "returns the declaration section for a completed lettings log" do
expect(form.next_incomplete_section_redirect_path(subsection, completed_lettings_log)).to eq("declaration")
lettings_log.first_time_property_let_as_social_housing = 1
expect(form.next_incomplete_section_redirect_path(subsection, lettings_log)).to eq("property-information/check-answers")
end
it "returns the next incomplete section by cycling back around if next subsections are completed" do
expect(form.next_incomplete_section_redirect_path(later_subsection, lettings_log)).to eq("armed-forces")
end
it "returns the declaration section if all sections are complete but the lettings log is in progress" do
answer_household_needs(lettings_log)
answer_tenancy_information(lettings_log)
answer_property_information(lettings_log)
answer_conditional_question(lettings_log)
answer_income_and_benefits(lettings_log)
answer_rent_and_charges(lettings_log)
answer_local_authority(lettings_log)
expect(form.next_incomplete_section_redirect_path(subsection, lettings_log)).to eq("declaration")
end
end
context "when no pages or questions in the next subsection are routed to" do
let(:subsection) { form.get_subsection("setup") }
around do |example|
FormHandler.instance.use_real_forms!
example.run
end
it "finds the path to the section after" do
lettings_log.startdate = Time.zone.local(2022, 9, 1)
lettings_log.renewal = 1
lettings_log.needstype = 2
lettings_log.postcode_known = 0
expect(form.next_incomplete_section_redirect_path(subsection, lettings_log)).to eq("joint")
expect(form.next_incomplete_section_redirect_path(later_subsection, lettings_log)).to eq("first-time-property-let-as-social-housing")
end
end
@ -239,11 +129,6 @@ RSpec.describe Form, type: :model do
let(:lettings_log) { build(:lettings_log, :completed, status: "in_progress") }
let(:subsection) { form.get_subsection("setup") }
before do
Timecop.return
FormHandler.instance.use_real_forms!
end
it "does not raise a Stack Error" do
expect { form.next_incomplete_section_redirect_path(subsection, lettings_log) }.not_to raise_error
end
@ -251,28 +136,21 @@ RSpec.describe Form, type: :model do
end
describe "#reset_not_routed_questions_and_invalid_answers" do
around do |example|
Singleton.__init__(FormHandler)
Timecop.freeze(now) do
FormHandler.instance.use_real_forms!
example.run
end
FormHandler.instance.use_fake_forms!
end
include CollectionTimeHelper
let(:now) { Time.zone.local(2023, 5, 5) }
let(:now) { current_collection_start_date }
context "when there are multiple radio questions for attribute X" do
context "and attribute Y is changed such that a different question for X is routed to" do
let(:log) { FactoryBot.create(:lettings_log, :setup_completed, :sheltered_housing, startdate: now, renewal: 0, prevten:) }
context "and the value of X remains valid" do
let(:prevten) { 36 }
let(:prevten) { 35 }
it "the value of this attribute is not cleared" do
log.renewal = 1
log.form.reset_not_routed_questions_and_invalid_answers(log)
expect(log.prevten).to be 36
expect(log.prevten).to be 35
end
end
@ -291,12 +169,13 @@ RSpec.describe Form, type: :model do
context "when there is one radio question for attribute X" do
context "and the start date or sale date is changed such that the collection year changes and there are different options" do
let(:log) { FactoryBot.create(:lettings_log, :setup_completed, :sheltered_housing, startdate: now, sheltered:) }
let(:previous_year_date) { previous_collection_start_date + 1.month }
context "and the value of X remains valid" do
let(:sheltered) { 2 }
it "the value of this attribute is not cleared" do
log.update!(startdate: Time.zone.local(2023, 1, 1))
log.update!(startdate: previous_year_date)
expect(log.sheltered).to be 2
end
end
@ -305,7 +184,7 @@ RSpec.describe Form, type: :model do
let(:sheltered) { 5 }
it "the value of this attribute is cleared" do
log.update!(startdate: Time.zone.local(2023, 1, 1))
log.update!(startdate: previous_year_date)
expect(log.sheltered).to be_nil
end
end
@ -327,7 +206,7 @@ RSpec.describe Form, type: :model do
context "when there are multiple free user input questions for attribute X" do
context "and attribute Y is changed such that a different question for X is routed to" do
let(:log) { FactoryBot.create(:sales_log, :saledate_today, :shared_ownership, :privacy_notice_seen, jointpur: 1, jointmore: 2, hholdcount: expected_hholdcount) }
let(:log) { FactoryBot.create(:sales_log, :shared_ownership_setup_complete, staircase: 2, jointpur: 1, jointmore: 2, hholdcount: expected_hholdcount) }
let(:expected_hholdcount) { 2 }
it "the value of this attribute is not cleared" do
@ -364,12 +243,12 @@ RSpec.describe Form, type: :model do
end
context "when a value is changed such that a radio and free input questions are no longer routed to" do
let(:log) { FactoryBot.create(:lettings_log, :completed, startdate: now, hhmemb: 2, details_known_2: 0, sex2: "M", relat2: "P", age2_known: 0, age2: 32, ecstat2: 6) }
let(:log) { FactoryBot.create(:lettings_log, :completed, startdate: now, hhmemb: 2, details_known_2: 0, sexrab2: "M", relat2: "P", age2_known: 0, age2: 32, ecstat2: 6) }
it "all attributes relating to that checkbox question are cleared" do
expect(log.hhmemb).to be 2
expect(log.details_known_2).to be 0
expect(log.sex2).to eq("M")
expect(log.sexrab2).to eq("M")
expect(log.relat2).to eq("P")
expect(log.age2_known).to be 0
expect(log.age2).to be 32
@ -377,7 +256,7 @@ RSpec.describe Form, type: :model do
log.update!(hhmemb: 1)
expect(log.details_known_2).to be_nil
expect(log.sex2).to be_nil
expect(log.sexrab2).to be_nil
expect(log.relat2).to be_nil
expect(log.age2_known).to be_nil
expect(log.age2).to be_nil
@ -386,13 +265,15 @@ RSpec.describe Form, type: :model do
end
context "when an attribute is derived, but no questions for that attribute are routed to" do
let(:log) { FactoryBot.create(:sales_log, :outright_sale_setup_complete, value: 200_000) }
let(:log) { FactoryBot.create(:lettings_log, :completed, startdate: now, unittype_gn: 2) }
it "the value of this attribute is not cleared" do
expect(log.deposit).to be_nil
log.update!(mortgageused: 2)
expect(log.form.questions.any? { |q| q.id == "deposit" && q.page.routed_to?(log, nil) }).to be false
expect(log.deposit).not_to be_nil
expect(log.is_bedsit?).to be true
expect(log.form.questions.any? { |q| q.id == "beds" && q.page.routed_to?(log, nil) }).to be false
expect(log.form.questions.any? { |q| q.id == "beds" && q.derived?(log) }).to be true
log.beds = 1
log.form.reset_not_routed_questions_and_invalid_answers(log)
expect(log.beds).to eq 1
end
end

Write Preview
Loading…
Cancel
Save