From 31b594d51c873d93834b2162e8a2ba6793f4531b Mon Sep 17 00:00:00 2001 From: magicmilo Date: Fri, 29 Oct 2021 13:37:27 +0100 Subject: [PATCH] switched to between for range --- app/models/case_log.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/case_log.rb b/app/models/case_log.rb index c0ab8bbd5..da8110796 100644 --- a/app/models/case_log.rb +++ b/app/models/case_log.rb @@ -119,13 +119,13 @@ class CaseLogValidator < ActiveModel::Validator unless record.household_number_of_other_members.nil? if record.household_number_of_other_members > 0 - if record.property_unit_type.include?("Shared") && (record.property_number_of_bedrooms.to_i == 0 || record.property_number_of_bedrooms.to_i > 7) + if record.property_unit_type.include?("Shared") && !record.property_number_of_bedrooms.to_i.between?(1, 7) record.errors.add :property_unit_type, "A shared house must have 1 to 7 bedrooms" end end end - if record.property_unit_type.include?("Shared") && (record.property_number_of_bedrooms.to_i == 0 || record.property_number_of_bedrooms.to_i > 3) + if record.property_unit_type.include?("Shared") && !record.property_number_of_bedrooms.to_i.between?(1, 3) record.errors.add :property_unit_type, "A shared house with less than two tenants must have 1 to 3 bedrooms" end end