From 3133696e362eb82b0a9b7b8c49633079cb142d56 Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Fri, 10 Feb 2023 17:09:16 +0000 Subject: [PATCH] refactor invert logic statement --- app/services/bulk_upload/lettings/row_parser.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/services/bulk_upload/lettings/row_parser.rb b/app/services/bulk_upload/lettings/row_parser.rb index 340fe8416..42e762be1 100644 --- a/app/services/bulk_upload/lettings/row_parser.rb +++ b/app/services/bulk_upload/lettings/row_parser.rb @@ -173,11 +173,11 @@ class BulkUpload::Lettings::RowParser private def validate_lettings_type_matches_bulk_upload - if [1, 3, 5, 7, 9, 11].include?(field_1) && bulk_upload.supported_housing? + if [1, 3, 5, 7, 9, 11].include?(field_1) && !bulk_upload.general_needs? errors.add(:field_1, I18n.t("validations.setup.lettype.supported_housing_mismatch")) end - if [2, 4, 6, 8, 10, 12].include?(field_1) && bulk_upload.general_needs? + if [2, 4, 6, 8, 10, 12].include?(field_1) && !bulk_upload.supported_housing? errors.add(:field_1, I18n.t("validations.setup.lettype.general_needs_mismatch")) end end