Browse Source

Fix flaky tests

pull/2524/head
Kat 2 years ago committed by kosiakkatrina
parent
commit
304a14452b
  1. 4
      spec/models/sales_log_spec.rb
  2. 2
      spec/models/scheme_spec.rb

4
spec/models/sales_log_spec.rb

@ -892,7 +892,7 @@ RSpec.describe SalesLog, type: :model do
end
context "when searching logs" do
let!(:sales_log_to_search) { create(:sales_log, purchid: "to search", postcode_full: "ME0 0WW") }
let!(:sales_log_to_search) { create(:sales_log, purchid: "to search", postcode_full: "ME0 0WW", id: 4_843_695) }
before do
create_list(:sales_log, 5, :completed)
@ -934,8 +934,6 @@ RSpec.describe SalesLog, type: :model do
describe "#search_by" do
it "allows searching using ID" do
sales_log_to_search.id += 30_000
sales_log_to_search.save!
result = described_class.search_by(sales_log_to_search.id.to_s)
expect(result.count).to eq(1)
expect(result.first.id).to eq sales_log_to_search.id

2
spec/models/scheme_spec.rb

@ -23,7 +23,7 @@ RSpec.describe Scheme, type: :model do
end
describe "scopes" do
let!(:scheme_1) { FactoryBot.create(:scheme) }
let!(:scheme_1) { FactoryBot.create(:scheme, id: 583_964) }
let!(:scheme_2) { FactoryBot.create(:scheme) }
let!(:location) { FactoryBot.create(:location, :export, scheme: scheme_1) }
let!(:location_2) { FactoryBot.create(:location, scheme: scheme_2, postcode: "NE4 6TR", name: "second location") }

Loading…
Cancel
Save