Browse Source

Clear beds over the max for the number of tenants

pull/1810/head
Kat 3 years ago
parent
commit
303d9af655
  1. 2
      app/models/validations/property_validations.rb
  2. 1
      app/services/imports/lettings_logs_import_service.rb
  3. 23
      spec/services/imports/lettings_logs_import_service_spec.rb

2
app/models/validations/property_validations.rb

@ -42,7 +42,7 @@ module Validations::PropertyValidations
if record.hhmemb == 1 && record.is_shared_housing? &&
!record.beds.to_i.between?(1, 3) && record.beds.present?
record.errors.add :unittype_gn, I18n.t("validations.property.unittype_gn.one_three_bedroom_single_tenant_shared")
record.errors.add :beds, I18n.t("validations.property.unittype_gn.one_three_bedroom_single_tenant_shared")
record.errors.add :beds, :one_three_bedroom_single_tenant_shared, message: I18n.t("validations.property.unittype_gn.one_three_bedroom_single_tenant_shared")
elsif record.is_shared_housing? && record.beds.present? && !record.beds.to_i.between?(1, 7)
record.errors.add :unittype_gn, I18n.t("validations.property.unittype_gn.one_seven_bedroom_shared")
record.errors.add :beds, I18n.t("validations.property.unittype_gn.one_seven_bedroom_shared")

1
app/services/imports/lettings_logs_import_service.rb

@ -323,6 +323,7 @@ module Imports
%i[voiddate after_mrcdate] => %w[voiddate mrcdate majorrepairs],
%i[tshortfall more_than_rent] => %w[tshortfall tshortfall_known],
%i[scheme_id no_completed_locations] => %w[scheme_id location_id],
%i[beds one_three_bedroom_single_tenant_shared] => %w[beds],
}
(2..8).each do |person|

23
spec/services/imports/lettings_logs_import_service_spec.rb

@ -535,6 +535,29 @@ RSpec.describe Imports::LettingsLogsImportService do
end
end
context "and beds over the max for the number of tenants" do
before do
lettings_log_xml.at_xpath("//xmlns:Q22").content = "4"
lettings_log_xml.at_xpath("//xmlns:HHMEMB").content = "1"
lettings_log_xml.at_xpath("//xmlns:Q23").content = "4"
end
it "intercepts the relevant validation error" do
expect { lettings_log_service.send(:create_log, lettings_log_xml) }
.not_to raise_error
end
it "clears out the bedrooms answer" do
allow(logger).to receive(:warn)
lettings_log_service.send(:create_log, lettings_log_xml)
lettings_log = LettingsLog.find_by(old_id: lettings_log_id)
expect(lettings_log).not_to be_nil
expect(lettings_log.beds).to be_nil
end
end
context "and carehome charges and other charges are entered" do
let(:lettings_log_id) { "0b4a68df-30cc-474a-93c0-a56ce8fdad3b" }

Loading…
Cancel
Save