From 2dc34f333744798f68820af444ff683accdaf8c6 Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire
 <94526761+natdeanlewissoftwire@users.noreply.github.com>
Date: Thu, 12 Oct 2023 17:20:49 +0100
Subject: [PATCH] CLDC-2824 Update bulk upload header guidance (#1975)

* feat: update copy in 23/24 lettings and sales prepare file pages

* feat: add full stops in alignment with designs
---
 .../forms/prepare_your_file_2022.html.erb             | 10 +++++-----
 .../forms/prepare_your_file_2023.html.erb             | 11 ++++++-----
 .../forms/prepare_your_file_2022.html.erb             | 10 +++++-----
 .../forms/prepare_your_file_2023.html.erb             | 11 ++++++-----
 4 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/app/views/bulk_upload_lettings_logs/forms/prepare_your_file_2022.html.erb b/app/views/bulk_upload_lettings_logs/forms/prepare_your_file_2022.html.erb
index 632f320a2..60fc158a2 100644
--- a/app/views/bulk_upload_lettings_logs/forms/prepare_your_file_2022.html.erb
+++ b/app/views/bulk_upload_lettings_logs/forms/prepare_your_file_2022.html.erb
@@ -21,9 +21,9 @@
       <h2 class="govuk-heading-s">Create your file</h2>
 
       <ul class="govuk-list govuk-list--bullet">
-        <li>Fill in the template with CORE data from your housing management system according to the <%= govuk_link_to "Lettings #{@form.year_combo} Bulk Upload Specification", @form.specification_path %></li>
-        <li><strong>Username field:</strong> To assign a log to someone else, enter the email address they use to log into CORE</li>
-        <li>If you have to manually enter large volumes of data into the bulk upload template, we recommend creating logs directly in the service instead. <%= govuk_link_to "Find out more about exporting your data", bulk_upload_lettings_log_path(id: "guidance", form: { year: @form.year }) %></li>
+        <li>Fill in the template with CORE data from your housing management system according to the <%= govuk_link_to "Lettings #{@form.year_combo} Bulk Upload Specification", @form.specification_path %>.</li>
+        <li><strong>Username field:</strong> To assign a log to someone else, enter the email address they use to log into CORE.</li>
+        <li>If you have to manually enter large volumes of data into the bulk upload template, we recommend creating logs directly in the service instead. <%= govuk_link_to "Find out more about exporting your data", bulk_upload_lettings_log_path(id: "guidance", form: { year: @form.year }) %>.</li>
       </ul>
 
       <%= govuk_inset_text(text: "Upload separate files for general needs and supported housing logs for 2022/23 data.") %>
@@ -31,8 +31,8 @@
       <h2 class="govuk-heading-s">Save your file</h2>
 
       <ul class="govuk-list govuk-list--bullet">
-        <li>Save your file as a CSV</li>
-        <li>Your file should now be ready to upload</li>
+        <li>Save your file as a CSV.</li>
+        <li>Your file should now be ready to upload.</li>
       </ul>
 
       <%= f.govuk_submit class: "govuk-!-margin-top-7" %>
diff --git a/app/views/bulk_upload_lettings_logs/forms/prepare_your_file_2023.html.erb b/app/views/bulk_upload_lettings_logs/forms/prepare_your_file_2023.html.erb
index f15972491..0dbd25c46 100644
--- a/app/views/bulk_upload_lettings_logs/forms/prepare_your_file_2023.html.erb
+++ b/app/views/bulk_upload_lettings_logs/forms/prepare_your_file_2023.html.erb
@@ -26,9 +26,10 @@
       <h2 class="govuk-heading-s">Create your file</h2>
 
       <ul class="govuk-list govuk-list--bullet">
-        <li>Fill in the template with CORE data from your housing management system according to the <%= govuk_link_to "Lettings #{@form.year_combo} Bulk Upload Specification", @form.specification_path %></li>
-        <li><strong>Username field:</strong> To assign a log to someone else, enter the email address they use to log into CORE</li>
-        <li>If you have to manually enter large volumes of data into the bulk upload template, we recommend creating logs directly in the service instead. <%= govuk_link_to "Find out more about exporting your data", bulk_upload_lettings_log_path(id: "guidance", form: { year: @form.year }) %></li>
+        <li>Fill in the template with CORE data from your housing management system according to the <%= govuk_link_to "Lettings #{@form.year_combo} Bulk Upload Specification", @form.specification_path %>.</li>
+        <li><strong>Username field:</strong> To assign a log to someone else, enter the email address they use to log into CORE.</li>
+        <li><strong>Headers:</strong> If you are using the new template, keep the headers. If you are using the legacy template, you can either keep or remove the headers.</li>
+        <li>If you have to manually enter large volumes of data into the bulk upload template, we recommend creating logs directly in the service instead. <%= govuk_link_to "Find out more about exporting your data", bulk_upload_lettings_log_path(id: "guidance", form: { year: @form.year }) %>.</li>
       </ul>
 
       <%= govuk_inset_text(text: "You can upload both general needs and supported housing logs in the same file for 2023/24 data.") %>
@@ -36,8 +37,8 @@
       <h2 class="govuk-heading-s">Save your file</h2>
 
       <ul class="govuk-list govuk-list--bullet">
-        <li>Save your file as a CSV</li>
-        <li>Your file should now be ready to upload</li>
+        <li>Save your file as a CSV.</li>
+        <li>Your file should now be ready to upload.</li>
       </ul>
 
       <%= f.govuk_submit class: "govuk-!-margin-top-7" %>
diff --git a/app/views/bulk_upload_sales_logs/forms/prepare_your_file_2022.html.erb b/app/views/bulk_upload_sales_logs/forms/prepare_your_file_2022.html.erb
index 624b3fe8b..fc1c1c31c 100644
--- a/app/views/bulk_upload_sales_logs/forms/prepare_your_file_2022.html.erb
+++ b/app/views/bulk_upload_sales_logs/forms/prepare_your_file_2022.html.erb
@@ -17,15 +17,15 @@
 
       <h2 class="govuk-heading-s">Create your file</h2>
       <ul class="govuk-list govuk-list--bullet">
-        <li>Fill in the template with CORE data from your housing management system according to the <%= govuk_link_to "Sales #{@form.year_combo} Bulk Upload Specification", @form.specification_path %></li>
-        <li><strong>Username field:</strong> To assign a log to someone else, enter the email address they use to log into CORE</li>
-        <li>If you have to manually enter large volumes of data into the bulk upload template, we recommend creating logs directly in the service instead. <%= govuk_link_to "Find out more about exporting your data", bulk_upload_sales_log_path(id: "guidance", form: { year: @form.year }) %></li>
+        <li>Fill in the template with CORE data from your housing management system according to the <%= govuk_link_to "Sales #{@form.year_combo} Bulk Upload Specification", @form.specification_path %>.</li>
+        <li><strong>Username field:</strong> To assign a log to someone else, enter the email address they use to log into CORE.</li>
+        <li>If you have to manually enter large volumes of data into the bulk upload template, we recommend creating logs directly in the service instead. <%= govuk_link_to "Find out more about exporting your data", bulk_upload_sales_log_path(id: "guidance", form: { year: @form.year }) %>.</li>
       </ul>
 
       <h2 class="govuk-heading-s">Save your file</h2>
       <ul class="govuk-list govuk-list--bullet">
-        <li>Save your file as a CSV</li>
-        <li>Your file should now be ready to upload</li>
+        <li>Save your file as a CSV.</li>
+        <li>Your file should now be ready to upload.</li>
       </ul>
 
       <%= f.govuk_submit %>
diff --git a/app/views/bulk_upload_sales_logs/forms/prepare_your_file_2023.html.erb b/app/views/bulk_upload_sales_logs/forms/prepare_your_file_2023.html.erb
index 7fc522e88..0d2d8831c 100644
--- a/app/views/bulk_upload_sales_logs/forms/prepare_your_file_2023.html.erb
+++ b/app/views/bulk_upload_sales_logs/forms/prepare_your_file_2023.html.erb
@@ -18,16 +18,17 @@
 
       <h2 class="govuk-heading-s">Create your file</h2>
       <ul class="govuk-list govuk-list--bullet">
-        <li>Fill in the template with CORE data from your housing management system according to the <%= govuk_link_to "Sales #{@form.year_combo} Bulk Upload Specification", @form.specification_path %></li>
-        <li><strong>Username field:</strong> To assign a log to someone else, enter the email address they use to log into CORE</li>
-        <li>If you have to manually enter large volumes of data into the bulk upload template, we recommend creating logs directly in the service instead. <%= govuk_link_to "Find out more about exporting your data", bulk_upload_sales_log_path(id: "guidance", form: { year: @form.year }) %></li>
+        <li>Fill in the template with CORE data from your housing management system according to the <%= govuk_link_to "Sales #{@form.year_combo} Bulk Upload Specification", @form.specification_path %>.</li>
+        <li><strong>Username field:</strong> To assign a log to someone else, enter the email address they use to log into CORE.</li>
+        <li><strong>Headers:</strong> If you are using the new template, keep the headers. If you are using the legacy template, you can either keep or remove the headers.</li>
+        <li>If you have to manually enter large volumes of data into the bulk upload template, we recommend creating logs directly in the service instead. <%= govuk_link_to "Find out more about exporting your data", bulk_upload_sales_log_path(id: "guidance", form: { year: @form.year }) %>.</li>
         <li>If you are using the new template, keep the headers. If you are using the legacy template, you can either keep or remove the headers.</li>
       </ul>
 
       <h2 class="govuk-heading-s">Save your file</h2>
       <ul class="govuk-list govuk-list--bullet">
-        <li>Save your file as a CSV</li>
-        <li>Your file should now be ready to upload</li>
+        <li>Save your file as a CSV.</li>
+        <li>Your file should now be ready to upload.</li>
       </ul>
 
       <%= f.govuk_submit %>