Use bulk_upload.year_combo for comparison in request tests to avoid year dependancy

spec/requests/bulk_upload_lettings_resume_controller_spec.rb

@@ -41,7 +41,7 @@ RSpec.describe BulkUploadLettingsResumeController, type: :request do
       expect(response).to be_successful
 
       expect(response.body).to include("Bulk upload for lettings")
-      expect(response.body).to include("2023/24")
+      expect(response.body).to include(bulk_upload.year_combo)
       expect(response.body).to include("View the error report")
       expect(response.body).to include("How would you like to fix the errors?")
       expect(response.body).to include(bulk_upload.filename)
@@ -180,7 +180,7 @@ RSpec.describe BulkUploadLettingsResumeController, type: :request do
       expect(response).to be_successful
 
       expect(response.body).to include("Bulk upload for lettings")
-      expect(response.body).to include("2023/24")
+      expect(response.body).to include(bulk_upload.year_combo)
       expect(response.body).to include("These 2 answers will be deleted if you upload the log")
       expect(response.body).to include(bulk_upload.filename)
       expect(response.body).to include("Clear this data and upload the logs")
@@ -222,7 +222,7 @@ RSpec.describe BulkUploadLettingsResumeController, type: :request do
         expect(response).to be_successful
 
         expect(response.body).to include("Bulk upload for lettings")
-        expect(response.body).to include("2023/24")
+        expect(response.body).to include(bulk_upload.year_combo)
         expect(response.body).to include("These 2 answers will be deleted if you upload the log")
         expect(response.body).to include(bulk_upload.filename)
         expect(response.body).to include("Clear this data and upload the logs")

spec/requests/bulk_upload_lettings_soft_validations_check_controller_spec.rb

@@ -15,7 +15,7 @@ RSpec.describe BulkUploadLettingsSoftValidationsCheckController, type: :request
       get "/lettings-logs/bulk-upload-soft-validations-check/#{bulk_upload.id}/confirm-soft-errors"
 
       expect(response.body).to include("Bulk upload for lettings")
-      expect(response.body).to include("2023/24")
+      expect(response.body).to include(bulk_upload.year_combo)
       expect(response.body).to include("Check these 2 answers")
       expect(response.body).to include(bulk_upload.filename)
       expect(response.body).to include("Are these fields correct?")