From 2b8ce1cab9ca51f7451e6cf5b4bbf7634ead28bf Mon Sep 17 00:00:00 2001 From: Jack S Date: Thu, 24 Nov 2022 10:15:37 +0000 Subject: [PATCH] Fix specs --- .../form/sales/pages/buyer1_mortgage.rb | 15 +++++++ .../form/sales/questions/buyer1_mortgage.rb | 16 ++++++++ .../income_benefits_and_savings.rb | 1 + .../form/sales/pages/buyer1_mortgage_spec.rb | 33 +++++++++++++++ .../sales/questions/buyer1_mortgage_spec.rb | 40 +++++++++++++++++++ .../form/sales/sections/finances_spec.rb | 2 +- .../income_benefits_and_savings_spec.rb | 1 + spec/models/form_handler_spec.rb | 4 +- 8 files changed, 109 insertions(+), 3 deletions(-) create mode 100644 app/models/form/sales/pages/buyer1_mortgage.rb create mode 100644 app/models/form/sales/questions/buyer1_mortgage.rb create mode 100644 spec/models/form/sales/pages/buyer1_mortgage_spec.rb create mode 100644 spec/models/form/sales/questions/buyer1_mortgage_spec.rb diff --git a/app/models/form/sales/pages/buyer1_mortgage.rb b/app/models/form/sales/pages/buyer1_mortgage.rb new file mode 100644 index 000000000..e17e9124b --- /dev/null +++ b/app/models/form/sales/pages/buyer1_mortgage.rb @@ -0,0 +1,15 @@ +class Form::Sales::Pages::Buyer1Mortgage < ::Form::Page + def initialize(id, hsh, subsection) + super + @id = "buyer_1_mortgage" + @header = "" + @description = "" + @subsection = subsection + end + + def questions + @questions ||= [ + Form::Sales::Questions::Buyer1Mortgage.new(nil, nil, self), + ] + end +end diff --git a/app/models/form/sales/questions/buyer1_mortgage.rb b/app/models/form/sales/questions/buyer1_mortgage.rb new file mode 100644 index 000000000..c524c3495 --- /dev/null +++ b/app/models/form/sales/questions/buyer1_mortgage.rb @@ -0,0 +1,16 @@ +class Form::Sales::Questions::Buyer1Mortgage < ::Form::Question + def initialize(id, hsh, page) + super + @id = "inc1mort" + @check_answer_label = "Buyer 1's income used for mortgage application" + @header = "Was buyer 1's income used for a mortgage application" + @type = "radio" + @answer_options = ANSWER_OPTIONS + @page = page + end + + ANSWER_OPTIONS = { + "1" => { "value" => "Yes" }, + "2" => { "value" => "No" }, + }.freeze +end diff --git a/app/models/form/sales/subsections/income_benefits_and_savings.rb b/app/models/form/sales/subsections/income_benefits_and_savings.rb index 920c01851..a9e7080db 100644 --- a/app/models/form/sales/subsections/income_benefits_and_savings.rb +++ b/app/models/form/sales/subsections/income_benefits_and_savings.rb @@ -10,6 +10,7 @@ class Form::Sales::Subsections::IncomeBenefitsAndSavings < ::Form::Subsection def pages @pages ||= [ Form::Sales::Pages::Buyer1Income.new(nil, nil, self), + Form::Sales::Pages::Buyer1Mortgage.new(nil, nil, self), ] end end diff --git a/spec/models/form/sales/pages/buyer1_mortgage_spec.rb b/spec/models/form/sales/pages/buyer1_mortgage_spec.rb new file mode 100644 index 000000000..d3aa2e1bb --- /dev/null +++ b/spec/models/form/sales/pages/buyer1_mortgage_spec.rb @@ -0,0 +1,33 @@ +require "rails_helper" + +RSpec.describe Form::Sales::Pages::Buyer1Mortgage, type: :model do + subject(:page) { described_class.new(page_id, page_definition, subsection) } + + let(:page_id) { nil } + let(:page_definition) { nil } + let(:subsection) { instance_double(Form::Subsection) } + + it "has correct subsection" do + expect(page.subsection).to eq(subsection) + end + + it "has correct questions" do + expect(page.questions.map(&:id)).to eq(%w[inc1mort]) + end + + it "has the correct id" do + expect(page.id).to eq("buyer_1_mortgage") + end + + it "has the correct header" do + expect(page.header).to eq("") + end + + it "has the correct description" do + expect(page.description).to eq("") + end + + it "has correct depends_on" do + expect(page.depends_on).to be_nil + end +end diff --git a/spec/models/form/sales/questions/buyer1_mortgage_spec.rb b/spec/models/form/sales/questions/buyer1_mortgage_spec.rb new file mode 100644 index 000000000..0e5f49117 --- /dev/null +++ b/spec/models/form/sales/questions/buyer1_mortgage_spec.rb @@ -0,0 +1,40 @@ +require "rails_helper" + +RSpec.describe Form::Sales::Questions::Buyer1Mortgage, type: :model do + subject(:question) { described_class.new(question_id, question_definition, page) } + + let(:question_id) { nil } + let(:question_definition) { nil } + let(:page) { instance_double(Form::Page) } + + it "has correct page" do + expect(question.page).to eq(page) + end + + it "has the correct id" do + expect(question.id).to eq("inc1mort") + end + + it "has the correct header" do + expect(question.header).to eq("Was buyer 1's income used for a mortgage application") + end + + it "has the correct check_answer_label" do + expect(question.check_answer_label).to eq("Buyer 1's income used for mortgage application") + end + + it "has the correct type" do + expect(question.type).to eq("radio") + end + + it "is not marked as derived" do + expect(question.derived?).to be false + end + + it "has the correct answer_options" do + expect(question.answer_options).to eq({ + "1" => { "value" => "Yes" }, + "2" => { "value" => "No" }, + }) + end +end diff --git a/spec/models/form/sales/sections/finances_spec.rb b/spec/models/form/sales/sections/finances_spec.rb index 4797f6b4e..6c2f63ded 100644 --- a/spec/models/form/sales/sections/finances_spec.rb +++ b/spec/models/form/sales/sections/finances_spec.rb @@ -14,7 +14,7 @@ RSpec.describe Form::Sales::Sections::Finances, type: :model do it "has correct subsections" do expect(section.subsections.map(&:id)).to eq( %w[ - income_benefits_and_outgoings + income_benefits_and_savings ], ) end diff --git a/spec/models/form/sales/subsections/income_benefits_and_savings_spec.rb b/spec/models/form/sales/subsections/income_benefits_and_savings_spec.rb index d1ed115b7..0ebbac6ab 100644 --- a/spec/models/form/sales/subsections/income_benefits_and_savings_spec.rb +++ b/spec/models/form/sales/subsections/income_benefits_and_savings_spec.rb @@ -15,6 +15,7 @@ RSpec.describe Form::Sales::Subsections::IncomeBenefitsAndSavings, type: :model expect(subsection.pages.map(&:id)).to eq( %w[ buyer_1_income + buyer_1_mortgage ], ) end diff --git a/spec/models/form_handler_spec.rb b/spec/models/form_handler_spec.rb index e0ef853ae..7db258b53 100644 --- a/spec/models/form_handler_spec.rb +++ b/spec/models/form_handler_spec.rb @@ -61,14 +61,14 @@ RSpec.describe FormHandler do it "is able to load a current sales form" do form = form_handler.get_form("current_sales") expect(form).to be_a(Form) - expect(form.pages.count).to eq(44) + expect(form.pages.count).to eq(45) expect(form.name).to eq("2022_2023_sales") end it "is able to load a previous sales form" do form = form_handler.get_form("previous_sales") expect(form).to be_a(Form) - expect(form.pages.count).to eq(44) + expect(form.pages.count).to eq(45) expect(form.name).to eq("2021_2022_sales") end end