From 29a98abfb290738d6c890974e2084c7c78e98564 Mon Sep 17 00:00:00 2001
From: Rachael Booth <rachael.booth@softwire.com>
Date: Wed, 5 Jun 2024 14:35:29 +0100
Subject: [PATCH] Try validations in rake tasks and log when needing to skip
 them

---
 lib/tasks/recalculate_vacdays.rake | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/tasks/recalculate_vacdays.rake b/lib/tasks/recalculate_vacdays.rake
index ee31c5cb8..38aa98f9b 100644
--- a/lib/tasks/recalculate_vacdays.rake
+++ b/lib/tasks/recalculate_vacdays.rake
@@ -2,9 +2,15 @@ desc "Recalculate vacdays after bugfix for daylight savings time changes"
 task recalculate_vacdays: :environment do
   logs = LettingsLog.where.not(vacdays: nil)
   logs.each do |log|
+    Rails.logger.log("Log #{log.id}")
     recalculated_vacdays = log.send(:property_vacant_days)
     next if recalculated_vacdays == log.vacdays
 
+    log.vacdays = recalculated_vacdays
+    next if log.save
+
+    Rails.logger.log("Log #{log.id} could not be saved, saving updated vacdays without validation")
+    log.reload
     log.vacdays = recalculated_vacdays
     log.save!(validate: false)
   end