From 28da18747393fe32cbaaeb2f76093e9da9e90f01 Mon Sep 17 00:00:00 2001 From: Arthur Campbell Date: Fri, 17 Mar 2023 10:24:06 +0000 Subject: [PATCH] when routing to a log show page, remove unnecessary :id call in url helper --- spec/features/lettings_log_spec.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/features/lettings_log_spec.rb b/spec/features/lettings_log_spec.rb index 0695a43e6..d3b540ab2 100644 --- a/spec/features/lettings_log_spec.rb +++ b/spec/features/lettings_log_spec.rb @@ -98,12 +98,12 @@ RSpec.describe "Lettings Log Features" do let(:lettings_log) { FactoryBot.create(:lettings_log, :about_completed) } it "has the correct breadcrumbs with the correct links" do - visit lettings_log_setup_check_answers_path(lettings_log.id) + visit lettings_log_setup_check_answers_path(lettings_log) breadcrumbs = page.find_all(".govuk-breadcrumbs__link") expect(breadcrumbs.first.text).to eq "Logs" expect(breadcrumbs.first[:href]).to eq lettings_logs_path expect(breadcrumbs[1].text).to eq "Log #{lettings_log.id}" - expect(breadcrumbs[1][:href]).to eq lettings_log_path(lettings_log.id) + expect(breadcrumbs[1][:href]).to eq lettings_log_path(lettings_log) end end @@ -111,12 +111,12 @@ RSpec.describe "Lettings Log Features" do let(:lettings_log) { FactoryBot.create(:lettings_log, :completed) } it "has the correct breadcrumbs with the correct links" do - visit review_lettings_log_path(lettings_log.id) + visit review_lettings_log_path(lettings_log) breadcrumbs = page.find_all(".govuk-breadcrumbs__link") expect(breadcrumbs.first.text).to eq "Logs" expect(breadcrumbs.first[:href]).to eq lettings_logs_path expect(breadcrumbs[1].text).to eq "Log #{lettings_log.id}" - expect(breadcrumbs[1][:href]).to eq lettings_log_path(lettings_log.id) + expect(breadcrumbs[1][:href]).to eq lettings_log_path(lettings_log) end end