Browse Source

feat: clear out of range proplen values

pull/1907/head
natdeanlewissoftwire 3 years ago
parent
commit
2891712c95
  1. 1
      app/services/imports/sales_logs_import_service.rb
  2. 25
      spec/services/imports/sales_logs_import_service_spec.rb

1
app/services/imports/sales_logs_import_service.rb

@ -259,6 +259,7 @@ module Imports
%i[mortgage cannot_be_0] => %w[mortgage],
%i[frombeds outside_the_range] => %w[frombeds],
%i[age1 outside_the_range] => %w[age1 age1_known],
%i[proplen outside_the_range] => %w[proplen],
}
errors.each do |(error, fields)|

25
spec/services/imports/sales_logs_import_service_spec.rb

@ -850,7 +850,7 @@ RSpec.describe Imports::SalesLogsImportService do
.not_to raise_error
end
it "clears out the referral answer" do
it "clears out the mortgage answer" do
allow(logger).to receive(:warn)
sales_log_service.send(:create_log, sales_log_xml)
@ -861,6 +861,29 @@ RSpec.describe Imports::SalesLogsImportService do
end
end
context "when proplen is out of range" do
let(:sales_log_id) { "shared_ownership_sales_log" }
before do
sales_log_xml.at_xpath("//xmlns:Q16aProplen2").content = "2000"
end
it "intercepts the relevant validation error" do
expect { sales_log_service.send(:create_log, sales_log_xml) }
.not_to raise_error
end
it "clears out the proplen answer" do
allow(logger).to receive(:warn)
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log).not_to be_nil
expect(sales_log.proplen).to be_nil
end
end
context "and it has an invalid income 1" do
let(:sales_log_id) { "shared_ownership_sales_log" }

Loading…
Cancel
Save