Browse Source

feat: update tests and underline css

pull/2155/head
natdeanlewissoftwire 2 years ago
parent
commit
28185f0675
  1. 4
      app/views/home/index.html.erb
  2. 2
      app/views/start/index.html.erb
  3. 7
      spec/requests/start_controller_spec.rb

4
app/views/home/index.html.erb

@ -48,9 +48,7 @@
</div>
<div class="govuk-grid-row">
<%= render partial: "layouts/collection_resources" %>
<div class="app-tab__underline">
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8">
</div>
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8 app-tab__underline">
<%= render partial: "home/upcoming_deadlines" %>
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8">
<%= render partial: "layouts/about_this_service" %>

2
app/views/start/index.html.erb

@ -25,7 +25,7 @@
<p class="govuk-body"><strong><%= govuk_link_to guidance_path do %>Guidance for submitting social housing lettings and sales data (CORE)<% end %></strong></p>
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8">
<%= render partial: "layouts/collection_resources" %>
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8">
<hr class="govuk-section-break govuk-section-break--visible govuk-section-break--m govuk-!-margin-top-8 govuk-!-margin-bottom-8 app-tab__underline">
<%= render partial: "layouts/about_this_service" %>
</div>
</div>

7
spec/requests/start_controller_spec.rb

@ -39,8 +39,15 @@ RSpec.describe StartController, type: :request do
it "displays correct resources for 2022/23 and 2023/24 collection years" do
get "/", headers: headers, params: {}
expect(page).to have_content("Lettings 24/25")
expect(page).to have_content("Lettings 23/24")
expect(page).to have_content("Lettings 2024 to 2025")
expect(page).to have_content("Lettings 2023 to 2024")
expect(page).to have_content("Sales 24/25")
expect(page).to have_content("Sales 23/24")
expect(page).to have_content("Sales 2024 to 2025")
expect(page).to have_content("Sales 2023 to 2024")
end
end

Loading…
Cancel
Save