diff --git a/app/models/form/sales/questions/mortgage_amount.rb b/app/models/form/sales/questions/mortgage_amount.rb index 49730dd13..f3ec338ee 100644 --- a/app/models/form/sales/questions/mortgage_amount.rb +++ b/app/models/form/sales/questions/mortgage_amount.rb @@ -20,6 +20,6 @@ class Form::Sales::Questions::MortgageAmount < ::Form::Question }.freeze def derived?(log) - log && log.mortgage_not_used? + log&.mortgage_not_used? end end diff --git a/spec/models/form/sales/questions/mortgage_amount_spec.rb b/spec/models/form/sales/questions/mortgage_amount_spec.rb index 37e0f6638..148d16506 100644 --- a/spec/models/form/sales/questions/mortgage_amount_spec.rb +++ b/spec/models/form/sales/questions/mortgage_amount_spec.rb @@ -48,18 +48,18 @@ RSpec.describe Form::Sales::Questions::MortgageAmount, type: :model do end context "when the mortgage is not used" do - let(:log) { create(:sales_log, :completed, mortgageused: 2, deposit: nil) } + let(:log) { build(:sales_log, :completed, mortgageused: 2, deposit: nil) } it "is marked as derived" do - expect(question.derived?(log)).to be true + expect(question).to be_derived(log) end end context "when the mortgage is used" do - let(:log) { create(:sales_log, :completed, mortgageused: 1) } + let(:log) { build(:sales_log, :completed, mortgageused: 1) } it "is marked as derived" do - expect(question.derived?(log)).to be false + expect(question).not_to be_derived(log) end end end