From 263f23123a12bebbf85caddefd23bb40ddc7b797 Mon Sep 17 00:00:00 2001 From: Rachael Booth Date: Fri, 7 Jun 2024 09:35:25 +0100 Subject: [PATCH] Keep previous punctuation --- app/services/bulk_upload/lettings/year2023/row_parser.rb | 6 +++--- app/services/bulk_upload/lettings/year2024/row_parser.rb | 8 ++++---- .../bulk_upload/lettings/year2024/row_parser_spec.rb | 1 + 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/app/services/bulk_upload/lettings/year2023/row_parser.rb b/app/services/bulk_upload/lettings/year2023/row_parser.rb index 93b82246d..51f772bcc 100644 --- a/app/services/bulk_upload/lettings/year2023/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2023/row_parser.rb @@ -339,7 +339,7 @@ class BulkUpload::Lettings::Year2023::RowParser validates :field_116, presence: { - message: I18n.t("validations.not_answered", question: "was the letting made under the Choice-Based Lettings (CBL)"), + message: I18n.t("validations.not_answered", question: "was the letting made under the Choice-Based Lettings (CBL)?"), category: :not_answered, }, inclusion: { @@ -351,7 +351,7 @@ class BulkUpload::Lettings::Year2023::RowParser validates :field_117, presence: { - message: I18n.t("validations.not_answered", question: "was the letting made under the Common Allocation Policy (CAP)"), + message: I18n.t("validations.not_answered", question: "was the letting made under the Common Allocation Policy (CAP)?"), category: :not_answered, }, inclusion: { @@ -363,7 +363,7 @@ class BulkUpload::Lettings::Year2023::RowParser validates :field_118, presence: { - message: I18n.t("validations.not_answered", question: "was the letting made under the Common Housing Register (CHR)"), + message: I18n.t("validations.not_answered", question: "was the letting made under the Common Housing Register (CHR)?"), category: :not_answered, }, inclusion: { diff --git a/app/services/bulk_upload/lettings/year2024/row_parser.rb b/app/services/bulk_upload/lettings/year2024/row_parser.rb index bff3b1166..688c58bdf 100644 --- a/app/services/bulk_upload/lettings/year2024/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2024/row_parser.rb @@ -339,7 +339,7 @@ class BulkUpload::Lettings::Year2024::RowParser validates :field_112, presence: { - message: I18n.t("validations.not_answered", question: "was the letting made under the Choice-Based Lettings (CBL)"), + message: I18n.t("validations.not_answered", question: "was the letting made under the Choice-Based Lettings (CBL)?"), category: :not_answered, }, inclusion: { @@ -351,7 +351,7 @@ class BulkUpload::Lettings::Year2024::RowParser validates :field_113, presence: { - message: I18n.t("validations.not_answered", question: "was the letting made under the Common Allocation Policy (CAP)"), + message: I18n.t("validations.not_answered", question: "was the letting made under the Common Allocation Policy (CAP)?"), category: :not_answered, }, inclusion: { @@ -363,7 +363,7 @@ class BulkUpload::Lettings::Year2024::RowParser validates :field_114, presence: { - message: I18n.t("validations.not_answered", question: "was the letting made under the Common Housing Register (CHR)"), + message: I18n.t("validations.not_answered", question: "was the letting made under the Common Housing Register (CHR)?"), category: :not_answered, }, inclusion: { @@ -375,7 +375,7 @@ class BulkUpload::Lettings::Year2024::RowParser validates :field_115, presence: { - message: I18n.t("validations.not_answered", question: "was the letting made under the Accessible Register"), + message: I18n.t("validations.not_answered", question: "was the letting made under the Accessible Register?"), category: :not_answered, }, inclusion: { diff --git a/spec/services/bulk_upload/lettings/year2024/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2024/row_parser_spec.rb index 435bc1c30..db3bbe716 100644 --- a/spec/services/bulk_upload/lettings/year2024/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2024/row_parser_spec.rb @@ -220,6 +220,7 @@ RSpec.describe BulkUpload::Lettings::Year2024::RowParser do field_112: "1", field_113: "2", field_114: "2", + field_115: "2", field_116: "2",