Kat
3 years ago
2 changed files with 478 additions and 0 deletions
@ -0,0 +1,358 @@ |
|||||||
|
module Imports |
||||||
|
class SalesLogsImportService < ImportService |
||||||
|
def initialize(storage_service, logger = Rails.logger) |
||||||
|
@logs_with_discrepancies = Set.new |
||||||
|
@logs_overridden = Set.new |
||||||
|
super |
||||||
|
end |
||||||
|
|
||||||
|
def create_logs(folder) |
||||||
|
import_from(folder, :create_log) |
||||||
|
if @logs_with_discrepancies.count.positive? |
||||||
|
@logger.warn("The following sales logs had status discrepancies: [#{@logs_with_discrepancies.join(', ')}]") |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
private |
||||||
|
|
||||||
|
def create_log(xml_doc) |
||||||
|
attributes = {} |
||||||
|
|
||||||
|
previous_status = meta_field_value(xml_doc, "status") |
||||||
|
|
||||||
|
# Required fields for status complete or logic to work |
||||||
|
# Note: order matters when we derive from previous values (attributes parameter) |
||||||
|
|
||||||
|
attributes["saledate"] = compose_date(xml_doc, "DAY", "MONTH", "YEAR") |
||||||
|
attributes["owning_organisation_id"] = find_organisation_id(xml_doc, "OWNINGORGID") |
||||||
|
attributes["type"] = unsafe_string_as_integer(xml_doc, "DERSALETYPE") |
||||||
|
attributes["old_id"] = meta_field_value(xml_doc, "document-id") |
||||||
|
attributes["created_at"] = Time.zone.parse(meta_field_value(xml_doc, "created-date")) |
||||||
|
attributes["updated_at"] = Time.zone.parse(meta_field_value(xml_doc, "modified-date")) |
||||||
|
attributes["purchid"] = string_or_nil(xml_doc, "PURCHASERCODE") |
||||||
|
attributes["ownershipsch"] = unsafe_string_as_integer(xml_doc, "OWNERSHIP") |
||||||
|
attributes["othtype"] = string_or_nil(xml_doc, "Q38OTHERSALE") |
||||||
|
attributes["jointmore"] = unsafe_string_as_integer(xml_doc, "JOINTMORE") |
||||||
|
attributes["jointpur"] = unsafe_string_as_integer(xml_doc, "JOINT") |
||||||
|
attributes["beds"] = safe_string_as_integer(xml_doc, "Q11BEDROOMS") |
||||||
|
attributes["companybuy"] = unsafe_string_as_integer(xml_doc, "COMPANY") |
||||||
|
attributes["hhmemb"] = safe_string_as_integer(xml_doc, "HHMEMB") |
||||||
|
(1..6).each do |index| |
||||||
|
attributes["age#{index}"] = safe_string_as_integer(xml_doc, "P#{index}AGE") |
||||||
|
attributes["sex#{index}"] = sex(xml_doc, index) |
||||||
|
attributes["ecstat#{index}"] = unsafe_string_as_integer(xml_doc, "P#{index}ECO") |
||||||
|
attributes["age#{index}_known"] = age_known(xml_doc, index, attributes["hhmemb"], attributes["age#{index}"]) |
||||||
|
end |
||||||
|
(2..6).each do |index| |
||||||
|
attributes["relat#{index}"] = relat(xml_doc, index) |
||||||
|
attributes["details_known_#{index}"] = details_known(index, attributes) |
||||||
|
end |
||||||
|
|
||||||
|
attributes["national"] = unsafe_string_as_integer(xml_doc, "P1NAT") |
||||||
|
attributes["othernational"] = nil |
||||||
|
attributes["ethnic"] = unsafe_string_as_integer(xml_doc, "P1ETH") |
||||||
|
attributes["ethnic_group"] = ethnic_group(attributes["ethnic"]) # check numbers |
||||||
|
attributes["buy1livein"] = nil # liveinbuyer1? |
||||||
|
attributes["buylivein"] = nil # liveinbuyer? liveinbuyerother? |
||||||
|
attributes["builtype"] = unsafe_string_as_integer(xml_doc, "Q13BUILDINGTYPE") |
||||||
|
attributes["proptype"] = unsafe_string_as_integer(xml_doc, "Q12PROPERTYTYPE") |
||||||
|
attributes["noint"] = safe_string_as_integer(xml_doc, "NOINT") |
||||||
|
attributes["buy2livein"] = # liveinbuyer2? |
||||||
|
attributes["privacynotice"] = nil # always yes? |
||||||
|
attributes["wheel"] = unsafe_string_as_integer(xml_doc, "Q10WHEELCHAIR") |
||||||
|
attributes["hholdcount"] = attributes["hhmemb"] - (attributes["jointpur"] == 1 ? 2 : 1) |
||||||
|
attributes["la"] = string_or_nil(xml_doc, "Q14ONSLACODE") |
||||||
|
attributes["la_known"] = # yes if LA is given? |
||||||
|
attributes["income1"] = safe_string_as_integer(xml_doc, "Q2PERSON1INCOME") # should this be decimal? |
||||||
|
attributes["income1nk"] = # ? |
||||||
|
attributes["inc1mort"] = safe_string_as_integer(xml_doc, "Q2PERSON1MORTGAGE") # should this be decimal? |
||||||
|
attributes["income2"] = safe_string_as_integer(xml_doc, "Q2PERSON2INCOME") # should this be decimal? |
||||||
|
attributes["income2nk"] = nil |
||||||
|
attributes["savingsnk"] = nil |
||||||
|
attributes["savings"] = safe_string_as_integer(xml_doc, "Q3SAVINGS") # should this be decimal? |
||||||
|
attributes["prevown"] = unsafe_string_as_integer(xml_doc, "Q4PREVOWNEDPROPERTY") |
||||||
|
attributes["mortgage"] = safe_string_as_decimal(xml_doc, "CALCMORT") |
||||||
|
attributes["inc2mort"] = safe_string_as_integer(xml_doc, "Q2PERSON2MORTAPPLICATION") # should this be decimal? |
||||||
|
attributes["hb"] = unsafe_string_as_integer(xml_doc, "Q2A") |
||||||
|
attributes["frombeds"] = safe_string_as_integer(xml_doc, "Q20BEDROOMS") |
||||||
|
attributes["staircase"] = unsafe_string_as_integer(xml_doc, "Q17ASTAIRCASE") |
||||||
|
attributes["stairbought"] = nil # ? |
||||||
|
attributes["stairowned"] = nil # ? |
||||||
|
attributes["mrent"] = safe_string_as_decimal(xml_doc, "Q28MONTHLYRENT") |
||||||
|
attributes["exdate"] = compose_date(xml_doc, "EXDAY", "EXMONTH", "EXYEAR") |
||||||
|
attributes["exday"] = safe_string_as_integer(xml_doc, "EXDAY") |
||||||
|
attributes["exmonth"] = safe_string_as_integer(xml_doc, "EXMONTH") |
||||||
|
attributes["exyear"] = safe_string_as_integer(xml_doc, "EXYEAR") |
||||||
|
attributes["resale"] = unsafe_string_as_integer(xml_doc, "Q17RESALE") |
||||||
|
attributes["deposit"] = safe_string_as_decimal(xml_doc, "Q26CASHDEPOSIT") |
||||||
|
attributes["cashdis"] = safe_string_as_decimal(xml_doc, "Q27SOCIALHOMEBUY") |
||||||
|
attributes["disabled"] = unsafe_string_as_integer(xml_doc, "DISABILITY") |
||||||
|
attributes["lanomagr"] = unsafe_string_as_integer(xml_doc, "Q19REHOUSED") |
||||||
|
attributes["soctenant"] = nil # ? |
||||||
|
attributes["value"] = safe_string_as_decimal(xml_doc, "Q22PURCHASEPRICE") |
||||||
|
attributes["equity"] = safe_string_as_decimal(xml_doc, "Q23EQUITY") |
||||||
|
attributes["discount"] = safe_string_as_decimal(xml_doc, "Q33DISCOUNT") |
||||||
|
attributes["grant"] = safe_string_as_decimal(xml_doc, "Q32REDUCTIONS") |
||||||
|
attributes["pregyrha"] = unsafe_string_as_integer(xml_doc, "PREGYRHA") |
||||||
|
attributes["pregla"] = unsafe_string_as_integer(xml_doc, "PREGLA") |
||||||
|
attributes["pregghb"] = nil # PREGHBA? |
||||||
|
attributes["pregother"] = unsafe_string_as_integer(xml_doc, "PREGOTHER") |
||||||
|
attributes["ppostcode_full"] = compose_postcode(xml_doc, "PPOSTC1", "PPOSTC2") |
||||||
|
attributes["prevloc"] = string_or_nil(xml_doc, "Q7ONSLACODE") |
||||||
|
# attributes["is_previous_la_inferred"] = nil |
||||||
|
attributes["ppcodenk"] = previous_postcode_known(xml_doc, attributes["ppostcode_full"], attributes["prevloc"]) # Q7UNKNOWNPOSTCODE check mapping |
||||||
|
attributes["ppostc1"] = string_or_nil(xml_doc, "PPOSTC1") |
||||||
|
attributes["ppostc2"] = string_or_nil(xml_doc, "PPOSTC2") |
||||||
|
attributes["previous_la_known"] = nil |
||||||
|
attributes["hhregres"] = unsafe_string_as_integer(xml_doc, "ARMEDF") |
||||||
|
attributes["hhregresstill"] = nil # ? |
||||||
|
attributes["proplen"] = safe_string_as_integer(xml_doc, "Q30A") |
||||||
|
attributes["mscharge_known"] = nil |
||||||
|
attributes["mscharge"] = safe_string_as_decimal(xml_doc, "Q29MONTHLYCHARGES") |
||||||
|
attributes["prevten"] = unsafe_string_as_integer(xml_doc, "Q6PREVTENURE") |
||||||
|
attributes["mortgageused"] = unsafe_string_as_integer(xml_doc, "MORTGAGEUSED") |
||||||
|
attributes["wchair"] = unsafe_string_as_integer(xml_doc, "Q15WHEELCHAIR") |
||||||
|
attributes["armedforcesspouse"] = unsafe_string_as_integer(xml_doc, "ARMEDFORCESSPOUSE") |
||||||
|
attributes["hodate"] = compose_date(xml_doc, "HODAY", "HOMONTH", "HOYEAR") |
||||||
|
attributes["hoday"] = safe_string_as_integer(xml_doc, "HODAY") |
||||||
|
attributes["homonth"] = safe_string_as_integer(xml_doc, "HOMONTH") |
||||||
|
attributes["hoyear"] = safe_string_as_integer(xml_doc, "HOYEAR") |
||||||
|
attributes["fromprop"] = unsafe_string_as_integer(xml_doc, "Q21PROPERTYTYPE") |
||||||
|
attributes["socprevten"] = nil # ? |
||||||
|
attributes["mortgagelender"] = nil # there's mortgagelender 1/2/3? Q24AMORTGAGELENDER Q34AMORTGAGELENDER Q41AMORTGAGELENDER |
||||||
|
attributes["mortgagelenderother"] = nil # Q24AMORTGAGELENDEROTHER Q34AMORTGAGELENDEROTHER Q41AMORTGAGELENDEROTHER |
||||||
|
attributes["mortlen"] = nil # there's mortlen 1/2/3? Q24B Q34B Q41B |
||||||
|
attributes["extrabor"] = unsafe_string_as_integer(xml_doc, "Q25BORROWING") |
||||||
|
attributes["totadult"] = safe_string_as_integer(xml_doc, "TOTADULT") # these would get overridden anyways |
||||||
|
attributes["totchild"] = safe_string_as_integer(xml_doc, "TOTCHILD") # these would get overridden anyways |
||||||
|
attributes["hhtype"] = unsafe_string_as_integer(xml_doc, "HHTYPE") |
||||||
|
attributes["pcode1"] = string_or_nil(xml_doc, "PCODE1") |
||||||
|
attributes["pcode2"] = string_or_nil(xml_doc, "PCODE2") |
||||||
|
attributes["pcodenk"] = nil # Q7UNKNOWNPOSTCODE check mapping |
||||||
|
attributes["postcode_full"] = compose_postcode(xml_doc, "PCODE1", "PCODE2") |
||||||
|
attributes["is_la_inferred"] = nil |
||||||
|
attributes["bulk_upload_id"] = nil |
||||||
|
attributes["saledate_check"] = nil |
||||||
|
attributes["ethnic_group2"] = nil |
||||||
|
attributes["ethnicbuy2"] = nil |
||||||
|
attributes["prevshared"] = nil |
||||||
|
attributes["staircasesale"] = nil |
||||||
|
|
||||||
|
# Sets the log creator |
||||||
|
owner_id = meta_field_value(xml_doc, "owner-user-id").strip |
||||||
|
if owner_id.present? |
||||||
|
user = LegacyUser.find_by(old_user_id: owner_id)&.user |
||||||
|
@logger.warn "Missing user! We expected to find a legacy user with old_user_id #{owner_id}" unless user |
||||||
|
|
||||||
|
attributes["created_by"] = user |
||||||
|
end |
||||||
|
|
||||||
|
sales_log = save_sales_log(attributes, previous_status) |
||||||
|
compute_differences(sales_log, attributes) |
||||||
|
check_status_completed(sales_log, previous_status) unless @logs_overridden.include?(sales_log.old_id) |
||||||
|
end |
||||||
|
|
||||||
|
def save_sales_log(attributes, previous_status) |
||||||
|
sales_log = SalesLog.new(attributes) |
||||||
|
binding.pry |
||||||
|
begin |
||||||
|
sales_log.save! |
||||||
|
sales_log |
||||||
|
rescue ActiveRecord::RecordNotUnique |
||||||
|
legacy_id = attributes["old_id"] |
||||||
|
record = SalesLog.find_by(old_id: legacy_id) |
||||||
|
@logger.info "Updating sal log #{record.id} with legacy ID #{legacy_id}" |
||||||
|
record.update!(attributes) |
||||||
|
record |
||||||
|
rescue ActiveRecord::RecordInvalid => e |
||||||
|
rescue_validation_or_raise(sales_log, attributes, previous_status, e) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
def rescue_validation_or_raise(sales_log, _attributes, _previous_status, exception) |
||||||
|
@logger.error("Log #{sales_log.old_id}: Failed to import") |
||||||
|
raise exception |
||||||
|
end |
||||||
|
|
||||||
|
def compute_differences(sales_log, attributes) |
||||||
|
differences = [] |
||||||
|
attributes.each do |key, value| |
||||||
|
sales_log_value = sales_log.send(key.to_sym) |
||||||
|
next if fields_not_present_in_softwire_data.include?(key) |
||||||
|
|
||||||
|
if value != sales_log_value |
||||||
|
differences.push("#{key} #{value.inspect} #{sales_log_value.inspect}") |
||||||
|
end |
||||||
|
end |
||||||
|
@logger.warn "Differences found when saving log #{sales_log.old_id}: #{differences}" unless differences.empty? |
||||||
|
end |
||||||
|
|
||||||
|
def fields_not_present_in_softwire_data |
||||||
|
%w[created_by |
||||||
|
income1_value_check |
||||||
|
mortgage_value_check |
||||||
|
savings_value_check |
||||||
|
deposit_value_check |
||||||
|
wheel_value_check |
||||||
|
retirement_value_check |
||||||
|
extrabor_value_check |
||||||
|
deposit_and_mortgage_value_check |
||||||
|
shared_ownership_deposit_value_check |
||||||
|
grant_value_check |
||||||
|
value_value_check |
||||||
|
old_persons_shared_ownership_value_check |
||||||
|
staircase_bought_value_check |
||||||
|
monthly_charges_value_check |
||||||
|
hodate_check] |
||||||
|
end |
||||||
|
|
||||||
|
def check_status_completed(sales_log, previous_status) |
||||||
|
if previous_status.include?("submitted") && sales_log.status != "completed" |
||||||
|
@logger.warn "sales log #{sales_log.id} is not completed" |
||||||
|
@logger.warn "sales log with old id:#{sales_log.old_id} is incomplete but status should be complete" |
||||||
|
@logs_with_discrepancies << sales_log.old_id |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
# Safe: A string that represents only an integer (or empty/nil) |
||||||
|
def safe_string_as_integer(xml_doc, attribute) |
||||||
|
str = field_value(xml_doc, "xmlns", attribute) |
||||||
|
Integer(str, exception: false) |
||||||
|
end |
||||||
|
|
||||||
|
# Unsafe: A string that has more than just the integer value |
||||||
|
def unsafe_string_as_integer(xml_doc, attribute) |
||||||
|
str = string_or_nil(xml_doc, attribute) |
||||||
|
if str.nil? |
||||||
|
nil |
||||||
|
else |
||||||
|
str.to_i |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
def compose_date(xml_doc, day_str, month_str, year_str) |
||||||
|
day = Integer(field_value(xml_doc, "xmlns", day_str), exception: false) |
||||||
|
month = Integer(field_value(xml_doc, "xmlns", month_str), exception: false) |
||||||
|
year = Integer(field_value(xml_doc, "xmlns", year_str), exception: false) |
||||||
|
if day.nil? || month.nil? || year.nil? |
||||||
|
nil |
||||||
|
else |
||||||
|
Time.zone.local(year, month, day) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
def find_organisation_id(xml_doc, id_field) |
||||||
|
old_visible_id = string_or_nil(xml_doc, id_field) |
||||||
|
organisation = Organisation.find_by(old_visible_id:) |
||||||
|
raise "Organisation not found with legacy ID #{old_visible_id}" if organisation.nil? |
||||||
|
|
||||||
|
organisation.id |
||||||
|
end |
||||||
|
|
||||||
|
def string_or_nil(xml_doc, attribute) |
||||||
|
str = field_value(xml_doc, "xmlns", attribute) |
||||||
|
str.presence |
||||||
|
end |
||||||
|
|
||||||
|
def ethnic_group(ethnic) |
||||||
|
case ethnic |
||||||
|
when 1, 2, 3, 18 |
||||||
|
# White |
||||||
|
0 |
||||||
|
when 4, 5, 6, 7 |
||||||
|
# Mixed |
||||||
|
1 |
||||||
|
when 8, 9, 10, 11, 15 |
||||||
|
# Asian |
||||||
|
2 |
||||||
|
when 12, 13, 14 |
||||||
|
# Black |
||||||
|
3 |
||||||
|
when 16, 19 |
||||||
|
# Others |
||||||
|
4 |
||||||
|
when 17 |
||||||
|
# Refused |
||||||
|
17 |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
def safe_string_as_decimal(xml_doc, attribute) |
||||||
|
str = string_or_nil(xml_doc, attribute) |
||||||
|
if str.nil? |
||||||
|
nil |
||||||
|
else |
||||||
|
BigDecimal(str, exception: false) |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
def compose_postcode(xml_doc, outcode, incode) |
||||||
|
outcode_value = string_or_nil(xml_doc, outcode) |
||||||
|
incode_value = string_or_nil(xml_doc, incode) |
||||||
|
if outcode_value.nil? || incode_value.nil? || !"#{outcode_value} #{incode_value}".match(POSTCODE_REGEXP) |
||||||
|
nil |
||||||
|
else |
||||||
|
"#{outcode_value} #{incode_value}" |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
def previous_postcode_known(xml_doc, previous_postcode, prevloc) |
||||||
|
previous_postcode_known = string_or_nil(xml_doc, "Q7UNKNOWNPOSTCODE") |
||||||
|
if previous_postcode_known == "If postcode not known tick" || (previous_postcode.nil? && prevloc.present?) |
||||||
|
1 |
||||||
|
elsif previous_postcode.nil? |
||||||
|
nil |
||||||
|
else |
||||||
|
0 |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
def sex(xml_doc, index) |
||||||
|
sex = string_or_nil(xml_doc, "P#{index}Sex") |
||||||
|
case sex |
||||||
|
when "Male" |
||||||
|
"M" |
||||||
|
when "Female" |
||||||
|
"F" |
||||||
|
when "Other", "Non-binary" |
||||||
|
"X" |
||||||
|
when "Refused" |
||||||
|
"R" |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
def relat(xml_doc, index) |
||||||
|
relat = string_or_nil(xml_doc, "P#{index}Rel") |
||||||
|
case relat |
||||||
|
when "Child" |
||||||
|
"C" |
||||||
|
when "Partner" |
||||||
|
"P" |
||||||
|
when "Other", "Non-binary" |
||||||
|
"X" |
||||||
|
when "Refused" |
||||||
|
"R" |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
def age_known(_xml_doc, index, hhmemb, age) |
||||||
|
return nil if hhmemb.present? && index > hhmemb |
||||||
|
|
||||||
|
return 0 if age.present? |
||||||
|
end |
||||||
|
|
||||||
|
def details_known(index, attributes) |
||||||
|
return nil if attributes["hhmemb"].nil? || index > attributes["hhmemb"] |
||||||
|
return nil if attributes["jointpur"] == 1 && index == 2 |
||||||
|
|
||||||
|
if attributes["age#{index}_known"] == 1 && |
||||||
|
attributes["sex#{index}"] == "R" && |
||||||
|
attributes["relat#{index}"] == "R" && |
||||||
|
attributes["ecstat#{index}"] == 10 |
||||||
|
2 # No |
||||||
|
else |
||||||
|
1 # Yes |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
@ -0,0 +1,120 @@ |
|||||||
|
require "rails_helper" |
||||||
|
|
||||||
|
RSpec.describe Imports::SalesLogsImportService do |
||||||
|
subject(:sales_log_service) { described_class.new(storage_service, logger) } |
||||||
|
|
||||||
|
let(:storage_service) { instance_double(Storage::S3Service) } |
||||||
|
let(:logger) { instance_double(ActiveSupport::Logger) } |
||||||
|
|
||||||
|
let(:fixture_directory) { "spec/fixtures/imports/sales_logs" } |
||||||
|
|
||||||
|
let(:organisation) { FactoryBot.create(:organisation, old_visible_id: "1", provider_type: "PRP") } |
||||||
|
let(:managing_organisation) { FactoryBot.create(:organisation, old_visible_id: "2", provider_type: "PRP") } |
||||||
|
|
||||||
|
def open_file(directory, filename) |
||||||
|
File.open("#{directory}/#{filename}.xml") |
||||||
|
end |
||||||
|
|
||||||
|
before do |
||||||
|
WebMock.stub_request(:get, /api.postcodes.io\/postcodes\/LS166FT/) |
||||||
|
.to_return(status: 200, body: '{"status":200,"result":{"admin_district":"Westminster","codes":{"admin_district":"E08000035"}}}', headers: {}) |
||||||
|
|
||||||
|
allow(Organisation).to receive(:find_by).and_return(nil) |
||||||
|
allow(Organisation).to receive(:find_by).with(old_visible_id: organisation.old_visible_id).and_return(organisation) |
||||||
|
allow(Organisation).to receive(:find_by).with(old_visible_id: managing_organisation.old_visible_id).and_return(managing_organisation) |
||||||
|
|
||||||
|
# Created by users |
||||||
|
FactoryBot.create(:user, old_user_id: "c3061a2e6ea0b702e6f6210d5c52d2a92612d2aa", organisation:) |
||||||
|
FactoryBot.create(:user, old_user_id: "e29c492473446dca4d50224f2bb7cf965a261d6f", organisation:) |
||||||
|
end |
||||||
|
|
||||||
|
context "when importing sales logs" do |
||||||
|
let(:remote_folder) { "sales_logs" } |
||||||
|
let(:sales_log_id) { "0ead17cb-1668-442d-898c-0d52879ff592" } |
||||||
|
let(:sales_log_id2) { "166fc004-392e-47a8-acb8-1c018734882b" } |
||||||
|
let(:sales_log_id3) { "00d2343e-d5fa-4c89-8400-ec3854b0f2b4" } |
||||||
|
let(:sales_log_id4) { "0b4a68df-30cc-474a-93c0-a56ce8fdad3b" } |
||||||
|
|
||||||
|
before do |
||||||
|
# Stub the S3 file listing and download |
||||||
|
allow(storage_service).to receive(:list_files) |
||||||
|
.and_return(%W[#{remote_folder}/#{sales_log_id}.xml #{remote_folder}/#{sales_log_id2}.xml #{remote_folder}/#{sales_log_id3}.xml #{remote_folder}/#{sales_log_id4}.xml]) |
||||||
|
allow(storage_service).to receive(:get_file_io) |
||||||
|
.with("#{remote_folder}/#{sales_log_id}.xml") |
||||||
|
.and_return(open_file(fixture_directory, sales_log_id), open_file(fixture_directory, sales_log_id)) |
||||||
|
allow(storage_service).to receive(:get_file_io) |
||||||
|
.with("#{remote_folder}/#{sales_log_id2}.xml") |
||||||
|
.and_return(open_file(fixture_directory, sales_log_id2), open_file(fixture_directory, sales_log_id2)) |
||||||
|
allow(storage_service).to receive(:get_file_io) |
||||||
|
.with("#{remote_folder}/#{sales_log_id3}.xml") |
||||||
|
.and_return(open_file(fixture_directory, sales_log_id3), open_file(fixture_directory, sales_log_id3)) |
||||||
|
allow(storage_service).to receive(:get_file_io) |
||||||
|
.with("#{remote_folder}/#{sales_log_id4}.xml") |
||||||
|
.and_return(open_file(fixture_directory, sales_log_id4), open_file(fixture_directory, sales_log_id4)) |
||||||
|
end |
||||||
|
|
||||||
|
it "successfully creates all sales logs" do |
||||||
|
expect(logger).not_to receive(:error) |
||||||
|
expect(logger).not_to receive(:warn) |
||||||
|
expect(logger).not_to receive(:info) |
||||||
|
expect { sales_log_service.create_logs(remote_folder) } |
||||||
|
.to change(SalesLog, :count).by(4) |
||||||
|
end |
||||||
|
|
||||||
|
it "only updates existing sales logs" do |
||||||
|
expect(logger).not_to receive(:error) |
||||||
|
expect(logger).not_to receive(:warn) |
||||||
|
expect(logger).to receive(:info).with(/Updating sales log/).exactly(4).times |
||||||
|
expect { 2.times { sales_log_service.create_logs(remote_folder) } } |
||||||
|
.to change(SalesLog, :count).by(4) |
||||||
|
end |
||||||
|
|
||||||
|
context "when there are status discrepancies" do |
||||||
|
let(:sales_log_id5) { "893ufj2s-lq77-42m4-rty6-ej09gh585uy1" } |
||||||
|
let(:sales_log_id6) { "5ybz29dj-l33t-k1l0-hj86-n4k4ma77xkcd" } |
||||||
|
let(:sales_log_file) { open_file(fixture_directory, sales_log_id5) } |
||||||
|
let(:sales_log_xml) { Nokogiri::XML(sales_log_file) } |
||||||
|
|
||||||
|
before do |
||||||
|
allow(storage_service).to receive(:get_file_io) |
||||||
|
.with("#{remote_folder}/#{sales_log_id5}.xml") |
||||||
|
.and_return(open_file(fixture_directory, sales_log_id5), open_file(fixture_directory, sales_log_id5)) |
||||||
|
allow(storage_service).to receive(:get_file_io) |
||||||
|
.with("#{remote_folder}/#{sales_log_id6}.xml") |
||||||
|
.and_return(open_file(fixture_directory, sales_log_id6), open_file(fixture_directory, sales_log_id6)) |
||||||
|
end |
||||||
|
|
||||||
|
it "the logger logs a warning with the sales log's old id/filename" do |
||||||
|
expect(logger).to receive(:warn).with(/is not completed/).once |
||||||
|
expect(logger).to receive(:warn).with(/sales log with old id:#{sales_log_id5} is incomplete but status should be complete/).once |
||||||
|
|
||||||
|
sales_log_service.send(:create_log, sales_log_xml) |
||||||
|
end |
||||||
|
|
||||||
|
it "on completion the ids of all logs with status discrepancies are logged in a warning" do |
||||||
|
allow(storage_service).to receive(:list_files) |
||||||
|
.and_return(%W[#{remote_folder}/#{sales_log_id5}.xml #{remote_folder}/#{sales_log_id6}.xml]) |
||||||
|
expect(logger).to receive(:warn).with(/is not completed/).twice |
||||||
|
expect(logger).to receive(:warn).with(/is incomplete but status should be complete/).twice |
||||||
|
expect(logger).to receive(:warn).with(/The following sales logs had status discrepancies: \[893ufj2s-lq77-42m4-rty6-ej09gh585uy1, 5ybz29dj-l33t-k1l0-hj86-n4k4ma77xkcd\]/) |
||||||
|
|
||||||
|
sales_log_service.create_logs(remote_folder) |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
|
|
||||||
|
context "when importing a specific log" do |
||||||
|
let(:sales_log_id) { "0ead17cb-1668-442d-898c-0d52879ff592" } |
||||||
|
let(:sales_log_file) { open_file(fixture_directory, sales_log_id) } |
||||||
|
let(:sales_log_xml) { Nokogiri::XML(sales_log_file) } |
||||||
|
|
||||||
|
context "and the organisation legacy ID does not exist" do |
||||||
|
before { sales_log_xml.at_xpath("//xmlns:OWNINGORGID").content = 99_999 } |
||||||
|
|
||||||
|
it "raises an exception" do |
||||||
|
expect { sales_log_service.send(:create_log, sales_log_xml) } |
||||||
|
.to raise_error(RuntimeError, "Organisation not found with legacy ID 99999") |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
|
end |
||||||
Loading…
Reference in new issue