From 23228a6bf7915a4ad16cbc2425545654fd16d0b5 Mon Sep 17 00:00:00 2001 From: Kat Date: Mon, 11 Sep 2023 12:03:44 +0100 Subject: [PATCH] Only blank tenancy lenght when it is invalid for tenancy type --- app/services/imports/lettings_logs_import_service.rb | 2 +- spec/services/imports/lettings_logs_import_service_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/services/imports/lettings_logs_import_service.rb b/app/services/imports/lettings_logs_import_service.rb index 49f1e4603..3fc28f92a 100644 --- a/app/services/imports/lettings_logs_import_service.rb +++ b/app/services/imports/lettings_logs_import_service.rb @@ -318,7 +318,7 @@ module Imports %i[chcharge out_of_range] => %w[chcharge], %i[referral internal_transfer_non_social_housing] => %w[referral], %i[referral internal_transfer_fixed_or_lifetime] => %w[referral], - %i[tenancylength tenancylength_invalid] => %w[tenancylength tenancy], + %i[tenancylength tenancylength_invalid] => %w[tenancylength], %i[prevten over_25_foster_care] => %w[prevten age1], %i[prevten non_temp_accommodation] => %w[prevten rsnvac], %i[joint not_joint_tenancy] => %w[joint], diff --git a/spec/services/imports/lettings_logs_import_service_spec.rb b/spec/services/imports/lettings_logs_import_service_spec.rb index c1eac29bb..123b23f1f 100644 --- a/spec/services/imports/lettings_logs_import_service_spec.rb +++ b/spec/services/imports/lettings_logs_import_service_spec.rb @@ -325,7 +325,7 @@ RSpec.describe Imports::LettingsLogsImportService do .not_to raise_error end - it "clears out the invalid answers" do + it "clears out the invalid tenancy lenght" do allow(logger).to receive(:warn) lettings_log_service.send(:create_log, lettings_log_xml) @@ -333,7 +333,7 @@ RSpec.describe Imports::LettingsLogsImportService do expect(lettings_log).not_to be_nil expect(lettings_log.tenancylength).to be_nil - expect(lettings_log.tenancy).to be_nil + expect(lettings_log.tenancy).to eq(4) end end