feat: simplify logic for incomplete status

Co-authored-by: James Rose <james@jbpr.net>
4 years ago · 20f9a470eb
1 changed files with 1 additions and 5 deletions
--- a/app/models/location.rb
+++ b/app/models/location.rb
@ -384,11 +384,7 @@ class Location < ApplicationRecord
  end

  def status(date = Time.zone.now)
-    return :incomplete if
-      postcode.blank? ||
-        units.blank? ||
-        type_of_unit.blank? ||
-        mobility_type.blank?
+    return :incomplete if [postcode, units, type_of_unit, mobility_type].any?(&:blank?)
    return :deactivated if open_deactivation&.deactivation_date.present? && date >= open_deactivation.deactivation_date
    return :deactivating_soon if open_deactivation&.deactivation_date.present? && date < open_deactivation.deactivation_date
    return :reactivating_soon if recent_deactivation&.reactivation_date.present? && date < recent_deactivation.reactivation_date