From 20326fd55b2c78f4d6f4178f160e8ae0429a325d Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
Date: Thu, 23 Mar 2023 09:11:09 +0000
Subject: [PATCH] feat: fix tests

---
 spec/helpers/schemes_helper_spec.rb               | 1 +
 spec/models/scheme_spec.rb                        | 1 +
 spec/models/validations/date_validations_spec.rb  | 2 ++
 spec/models/validations/setup_validations_spec.rb | 2 ++
 spec/requests/schemes_controller_spec.rb          | 7 +++++++
 5 files changed, 13 insertions(+)

diff --git a/spec/helpers/schemes_helper_spec.rb b/spec/helpers/schemes_helper_spec.rb
index 77f178f62..88b824b80 100644
--- a/spec/helpers/schemes_helper_spec.rb
+++ b/spec/helpers/schemes_helper_spec.rb
@@ -106,6 +106,7 @@ RSpec.describe SchemesHelper do
                         intended_stay: "P",
                         created_at: Time.zone.local(2022, 4, 1))
     end
+    let!(:location) { FactoryBot.create(:location, scheme:) }
     let!(:scheme_where_managing_organisation_is_owning_organisation) { FactoryBot.create(:scheme, arrangement_type: "D") }
     let(:support_user) { FactoryBot.create(:user, :support) }
     let(:coordinator_user) { FactoryBot.create(:user, :data_coordinator) }
diff --git a/spec/models/scheme_spec.rb b/spec/models/scheme_spec.rb
index f59fe56c5..f6daf6fe7 100644
--- a/spec/models/scheme_spec.rb
+++ b/spec/models/scheme_spec.rb
@@ -94,6 +94,7 @@ RSpec.describe Scheme, type: :model do
 
   describe "status" do
     let(:scheme) { FactoryBot.build(:scheme) }
+    let!(:location) { FactoryBot.create(:location, scheme:) }
 
     before do
       Timecop.freeze(2022, 6, 7)
diff --git a/spec/models/validations/date_validations_spec.rb b/spec/models/validations/date_validations_spec.rb
index cd6e38f50..1211b7ef7 100644
--- a/spec/models/validations/date_validations_spec.rb
+++ b/spec/models/validations/date_validations_spec.rb
@@ -171,6 +171,7 @@ RSpec.describe Validations::DateValidations do
 
     context "with a scheme that is reactivating soon" do
       let(:scheme) { create(:scheme) }
+      let!(:location) { FactoryBot.create(:location, scheme:) }
 
       before do
         create(:scheme_deactivation_period, deactivation_date: Time.zone.local(2022, 6, 4), reactivation_date: Time.zone.local(2022, 8, 4), scheme:)
@@ -195,6 +196,7 @@ RSpec.describe Validations::DateValidations do
 
     context "with a scheme that has many reactivations soon" do
       let(:scheme) { create(:scheme) }
+      let!(:location) { FactoryBot.create(:location, scheme:) }
 
       before do
         create(:scheme_deactivation_period, deactivation_date: Time.zone.local(2022, 6, 4), reactivation_date: Time.zone.local(2022, 8, 4), scheme:)
diff --git a/spec/models/validations/setup_validations_spec.rb b/spec/models/validations/setup_validations_spec.rb
index 69e22f1e2..c1c9c27c9 100644
--- a/spec/models/validations/setup_validations_spec.rb
+++ b/spec/models/validations/setup_validations_spec.rb
@@ -186,6 +186,7 @@ RSpec.describe Validations::SetupValidations do
 
     context "with a scheme that is reactivating soon" do
       let(:scheme) { create(:scheme, created_at: Time.zone.local(2022, 4, 1)) }
+      let!(:location) { FactoryBot.create(:location, scheme:) }
 
       before do
         create(:scheme_deactivation_period, deactivation_date: Time.zone.local(2022, 6, 4), reactivation_date: Time.zone.local(2022, 8, 4), scheme:)
@@ -210,6 +211,7 @@ RSpec.describe Validations::SetupValidations do
 
     context "with a scheme that has many reactivations soon" do
       let(:scheme) { create(:scheme, created_at: Time.zone.local(2022, 4, 1)) }
+      let!(:location) { FactoryBot.create(:location, scheme:) }
 
       before do
         create(:scheme_deactivation_period, deactivation_date: Time.zone.local(2022, 6, 4), reactivation_date: Time.zone.local(2022, 8, 4), scheme:)
diff --git a/spec/requests/schemes_controller_spec.rb b/spec/requests/schemes_controller_spec.rb
index 431270767..af4a83560 100644
--- a/spec/requests/schemes_controller_spec.rb
+++ b/spec/requests/schemes_controller_spec.rb
@@ -7,6 +7,12 @@ RSpec.describe SchemesController, type: :request do
   let(:user) { FactoryBot.create(:user, :support) }
   let!(:schemes) { FactoryBot.create_list(:scheme, 5) }
 
+  before do
+    schemes.each do |scheme|
+      FactoryBot.create(:location, scheme:)
+    end
+  end
+
   describe "#index" do
     context "when not signed in" do
       it "redirects to the sign in page" do
@@ -258,6 +264,7 @@ RSpec.describe SchemesController, type: :request do
         let(:user) { FactoryBot.create(:user, :data_coordinator) }
         let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) }
         let(:add_deactivations) { scheme.scheme_deactivation_periods << scheme_deactivation_period }
+        let!(:location) { FactoryBot.create(:location, scheme:) }
 
         before do
           Timecop.freeze(Time.utc(2022, 10, 10))