Refactor

app/services/bulk_upload/lettings/year2023/row_parser.rb

@@ -435,12 +435,14 @@ class BulkUpload::Lettings::Year2023::RowParser
       fields = field_mapping_for_errors[error.attribute] || []
 
       fields.each do |field|
-        unless errors.include?(field)
+        next if errors.include?(field)
-          if error.attribute == :owning_organisation_id || error.attribute == :managing_organisation_id || error.attribute == :startdate
+
-            errors.add(field, error.message, category: :setup)
+        question = log.form.get_question(error.attribute, log)
-          else
+
-            errors.add(field, error.message)
+        if question.present? && setup_question?(question)
-          end
+          errors.add(field, error.message, category: :setup)
+        else
+          errors.add(field, error.message)
         end
       end
     end