Browse Source

feat: don't add empty assignments in field_mapping_for_errors

pull/2135/head
natdeanlewissoftwire 2 years ago
parent
commit
1bd94c1a4c
  1. 10
      app/services/bulk_upload/lettings/year2023/row_parser.rb
  2. 2
      config/locales/en.yml

10
app/services/bulk_upload/lettings/year2023/row_parser.rb

@ -893,10 +893,10 @@ private
owning_organisation_id: [:field_1],
managing_organisation_id: [:field_2],
renewal: [:field_6],
scheme_id: [scheme_field],
scheme: [scheme_field],
location_id: [location_field],
location: [location_field],
scheme_id: (scheme_field.present? ? [scheme_field] : nil),
scheme: (scheme_field.present? ? [scheme_field] : nil),
location_id: (location_field.present? ? [location_field] : nil),
location: (location_field.present? ? [location_field] : nil),
created_by: [:field_3],
needstype: [:field_4],
rent_type: %i[field_5 field_10 field_11],
@ -1040,7 +1040,7 @@ private
address_line2: [:field_20],
town_or_city: [:field_21],
county: [:field_22],
}
}.compact
end
def attribute_set

2
config/locales/en.yml

@ -353,7 +353,7 @@ en:
financial:
tshortfall:
outstanding_amount_not_expected: "You cannot answer the outstanding amount question if you don’t have outstanding rent or charges"
more_than_rent: "Enter a value less less than the basic rent amount"
more_than_rent: "Enter a value less than the basic rent amount"
must_be_positive: "Enter a value over £0.01 as you told us there is an outstanding amount"
hbrentshortfall:
outstanding_amount_not_expected: "Answer must be ‘yes’ as you have answered the outstanding amount question"

Loading…
Cancel
Save