From 1ba844197bd8c58f4d60a46e0f02a04111e66cc9 Mon Sep 17 00:00:00 2001 From: Kat Date: Fri, 21 Jun 2024 15:17:26 +0100 Subject: [PATCH] Refactor --- spec/requests/lettings_logs_controller_spec.rb | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/spec/requests/lettings_logs_controller_spec.rb b/spec/requests/lettings_logs_controller_spec.rb index ed551c330..19fda86af 100644 --- a/spec/requests/lettings_logs_controller_spec.rb +++ b/spec/requests/lettings_logs_controller_spec.rb @@ -1869,15 +1869,22 @@ RSpec.describe LettingsLogsController, type: :request do context "when filtering by organisation and year" do let(:other_organisation) { FactoryBot.create(:organisation) } let(:lettings_logs) { create_list(:lettings_log, 2, :setup_completed, assigned_to: user, owning_organisation: other_organisation, managing_organisation: user.organisation) } + let(:params) do + { + years: [lettings_logs[0].form.start_date.year], + owning_organisation: other_organisation.id, + owning_organisation_select: "specific_org", + codes_only: false, + } + end before do create(:organisation_relationship, parent_organisation: other_organisation, child_organisation: user.organisation) - lettings_logs create_list(:lettings_log, 2, :setup_completed, assigned_to: user, owning_organisation: other_organisation, managing_organisation: user.organisation, discarded_at: Time.zone.yesterday) end it "does not count deleted logs" do - get "/lettings-logs/csv-download?years[]=#{lettings_logs[0].form.start_date.year}&codes_only=false&owning_organisation_select=specific_org&owning_organisation=#{other_organisation.id}", headers:, params: {} + get csv_download_lettings_logs_path, headers:, params: params expect(page).to have_content("You've selected 2 logs.") end