update model tests

spec/models/bulk_upload_spec.rb

@@ -39,8 +39,8 @@ RSpec.describe BulkUpload, type: :model do
 
   describe "year_combo" do
     [
-      { year: 2023, expected_value: "2023/24" },
-      { year: 2024, expected_value: "2024/25" },
+      { year: 2023, expected_value: "2023 to 2024" },
+      { year: 2024, expected_value: "2024 to 2025" },
     ].each do |test_case|
       context "when the bulk upload year is #{test_case[:year]}" do
         let(:bulk_upload) { build(:bulk_upload, year: test_case[:year]) }

spec/models/forms/bulk_upload_lettings/year_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe Forms::BulkUploadLettings::Year do
 
       it "returns current and previous years" do
         expect(form.options.map(&:id)).to eql([2024, 2023])
-        expect(form.options.map(&:name)).to eql(%w[2024/2025 2023/2024])
+        expect(form.options.map(&:name)).to eql(["2024 to 2025", "2023 to 2024"])
       end
     end
 
@@ -28,7 +28,7 @@ RSpec.describe Forms::BulkUploadLettings::Year do
 
       it "returns the current year" do
         expect(form.options.map(&:id)).to eql([2024])
-        expect(form.options.map(&:name)).to eql(%w[2024/2025])
+        expect(form.options.map(&:name)).to eql(["2024 to 2025"])
       end
     end
 
@@ -40,7 +40,7 @@ RSpec.describe Forms::BulkUploadLettings::Year do
 
       it "returns current and next years" do
         expect(form.options.map(&:id)).to eql([2024, 2025])
-        expect(form.options.map(&:name)).to eql(%w[2024/2025 2025/2026])
+        expect(form.options.map(&:name)).to eql(["2024 to 2025", "2025 to 2026"])
       end
     end
   end

spec/models/forms/bulk_upload_sales/year_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe Forms::BulkUploadSales::Year do
 
       it "returns current and previous years" do
         expect(form.options.map(&:id)).to eql([2024, 2023])
-        expect(form.options.map(&:name)).to eql(%w[2024/2025 2023/2024])
+        expect(form.options.map(&:name)).to eql(["2024 to 2025", "2023 to 2024"])
       end
     end
 
@@ -28,7 +28,7 @@ RSpec.describe Forms::BulkUploadSales::Year do
 
       it "returns the current year" do
         expect(form.options.map(&:id)).to eql([2024])
-        expect(form.options.map(&:name)).to eql(%w[2024/2025])
+        expect(form.options.map(&:name)).to eql(["2024 to 2025"])
       end
     end
 
@@ -44,7 +44,7 @@ RSpec.describe Forms::BulkUploadSales::Year do
 
       it "returns current and next years" do
         expect(form.options.map(&:id)).to eql([2024, 2025])
-        expect(form.options.map(&:name)).to eql(%w[2024/2025 2025/2026])
+        expect(form.options.map(&:name)).to eql(["2024 to 2025", "2025 to 2026"])
       end
     end
   end