Browse Source

refactor: simplification

pull/1768/head
natdeanlewissoftwire 3 years ago
parent
commit
1985019fef
  1. 16
      app/helpers/filters_helper.rb

16
app/helpers/filters_helper.rb

@ -47,21 +47,25 @@ module FiltersHelper
end end
def filters_applied_text(filter_type) def filters_applied_text(filter_type)
applied_filters = JSON.parse(session[session_name_for(filter_type)]) applied_filters_count(filter_type).zero? ? "No filters applied" : "#{pluralize(applied_filters_count(filter_type), 'filter')} applied"
applied_filters_count = filters_count(applied_filters)
applied_filters_count.zero? ? "No filters applied" : "#{pluralize(applied_filters_count, 'filter')} applied"
end end
def reset_filters_link(filter_type) def reset_filters_link(filter_type)
applied_filters = JSON.parse(session[session_name_for(filter_type)]) if applied_filters_count(filter_type).positive?
applied_filters_count = filters_count(applied_filters)
if applied_filters_count.positive?
govuk_link_to "Clear", clear_filters_path(filter_type:) govuk_link_to "Clear", clear_filters_path(filter_type:)
end end
end end
private private
def applied_filters_count(filter_type)
filters_count(applied_filters(filter_type))
end
def applied_filters(filter_type)
JSON.parse(session[session_name_for(filter_type)])
end
def session_name_for(filter_type) def session_name_for(filter_type)
"#{filter_type}_filters" "#{filter_type}_filters"
end end

Loading…
Cancel
Save