From 16e1ffde0f9ad37ee1a24be67d026b3788573ef8 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Mon, 10 Mar 2025 09:01:52 +0000
Subject: [PATCH] CLDC-3896: Remove "Answer" button from soft validation check
 errors page (#2973)

* Hide link if question is unanswered

* Remove "Answer" text

* Lint

* Update tests
---
 app/helpers/check_errors_helper.rb            | 2 +-
 app/views/form/check_errors.html.erb          | 2 +-
 spec/requests/check_errors_controller_spec.rb | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/helpers/check_errors_helper.rb b/app/helpers/check_errors_helper.rb
index 3b3774566..c23b89c40 100644
--- a/app/helpers/check_errors_helper.rb
+++ b/app/helpers/check_errors_helper.rb
@@ -2,7 +2,7 @@ module CheckErrorsHelper
   include GovukLinkHelper
 
   def check_errors_answer_text(question, log)
-    question.displayed_as_answered?(log) ? "Change" : "Answer"
+    question.displayed_as_answered?(log) ? "Change" : ""
   end
 
   def check_errors_answer_link(log, question, page, applicable_questions)
diff --git a/app/views/form/check_errors.html.erb b/app/views/form/check_errors.html.erb
index df297b891..c7b08701d 100644
--- a/app/views/form/check_errors.html.erb
+++ b/app/views/form/check_errors.html.erb
@@ -50,7 +50,7 @@
                 </dd>
                 <dd class="govuk-summary-list__actions">
                   <% if !question.displayed_as_answered?(@log) || question.subsection.id == "setup" %>
-                    <%= govuk_link_to check_errors_answer_text(question, @log), check_errors_answer_link(@log, question, @page, applicable_questions) %>
+                    <%= govuk_link_to check_errors_answer_text(question, @log), check_errors_answer_link(@log, question, @page, applicable_questions) unless question.unanswered?(@log) %>
                   <% else %>
                     <input type="submit" value="Clear" class="govuk-body govuk-link submit-button-link" name="<%= question.id %>">
                   <% end %>
diff --git a/spec/requests/check_errors_controller_spec.rb b/spec/requests/check_errors_controller_spec.rb
index 71a83a3fa..186bb8749 100644
--- a/spec/requests/check_errors_controller_spec.rb
+++ b/spec/requests/check_errors_controller_spec.rb
@@ -295,7 +295,7 @@ RSpec.describe CheckErrorsController, type: :request do
         it "displays correct clear links" do
           expect(page).to have_content("Make sure these answers are correct")
           expect(page).to have_link(lettings_log.form.get_question("hhmemb", lettings_log).check_answer_prompt, href: "/lettings-logs/#{lettings_log.id}/household-members?referrer=check_answers_new_answer", class: "govuk-link govuk-link--no-visited-state")
-          expect(page).to have_link("Answer")
+          expect(page).to have_link("Enter total number of household members")
           expect(lettings_log.reload.earnings).to eq(nil)
         end
       end
@@ -350,7 +350,7 @@ RSpec.describe CheckErrorsController, type: :request do
         it "displays correct clear links" do
           expect(page).to have_content("Make sure these answers are correct")
           expect(page).to have_link(sales_log.form.get_question("income1", sales_log).check_answer_prompt, href: "/sales-logs/#{sales_log.id}/buyer-1-income?referrer=check_answers_new_answer", class: "govuk-link govuk-link--no-visited-state")
-          expect(page).to have_link("Answer")
+          expect(page).to have_link("Enter buyer 1’s gross annual income")
           expect(sales_log.reload.income1).to eq(nil)
         end
       end