From 139ae7d5d030aa9391005ed46105848d85f99e0f Mon Sep 17 00:00:00 2001 From: Rachael Booth Date: Wed, 12 Jun 2024 14:32:19 +0100 Subject: [PATCH] Only change strictness when discount is present --- app/models/validations/sales/sale_information_validations.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/validations/sales/sale_information_validations.rb b/app/models/validations/sales/sale_information_validations.rb index e2d737002..979757e51 100644 --- a/app/models/validations/sales/sale_information_validations.rb +++ b/app/models/validations/sales/sale_information_validations.rb @@ -50,7 +50,7 @@ module Validations::Sales::SaleInformationValidations # When a percentage discount is used, a percentage tolerance is needed to account for rounding errors tolerance = record.discount ? record.value * 0.05 / 100 : 1 - if over_tolerance?(record.mortgage_deposit_and_grant_total, record.value_with_discount, tolerance, strict: true) && record.discounted_ownership_sale? + if over_tolerance?(record.mortgage_deposit_and_grant_total, record.value_with_discount, tolerance, strict: !record.discount.nil?) && record.discounted_ownership_sale? %i[mortgageused mortgage value deposit ownershipsch discount grant].each do |field| record.errors.add field, I18n.t("validations.sale_information.discounted_ownership_value", mortgage_deposit_and_grant_total: record.field_formatted_as_currency("mortgage_deposit_and_grant_total"), value_with_discount: record.field_formatted_as_currency("value_with_discount")) end