do not create logs if a setup section not complete

app/services/bulk_upload/lettings/validator.rb

@@ -171,6 +171,8 @@ class BulkUpload::Lettings::Validator
   end
 
   def create_logs?
+    return false if row_parsers.any? { |row_parser| row_parser.log.form.setup_sections[0].subsections[0].is_incomplete?(row_parser.log) }
+
     row_parsers.all? { |row_parser| row_parser.log.valid? }
   end
 

spec/services/bulk_upload/lettings/validator_spec.rb

@@ -130,8 +130,8 @@ RSpec.describe BulkUpload::Lettings::Validator do
     end
 
     context "when all logs valid?" do
-      let(:log_1) { build(:lettings_log, :completed, created_by: user) }
+      let(:log_1) { build(:lettings_log, :completed, renttype: 1, created_by: user) }
-      let(:log_2) { build(:lettings_log, :completed, created_by: user) }
+      let(:log_2) { build(:lettings_log, :completed, renttype: 1, created_by: user) }
 
       before do
         file.write(BulkUpload::LogToCsv.new(log: log_1, line_ending: "\r\n", col_offset: 0).to_csv_row)
@@ -143,5 +143,18 @@ RSpec.describe BulkUpload::Lettings::Validator do
         expect(validator).to be_create_logs
       end
     end
+
+    context "when a log has incomplete setup secion" do
+      let(:log) { build(:lettings_log, :in_progress, created_by: user, startdate: Time.zone.local(2022, 5, 1)) }
+
+      before do
+        file.write(BulkUpload::LogToCsv.new(log:, line_ending: "\r\n", col_offset: 0).to_csv_row)
+        file.close
+      end
+
+      it "returns false" do
+        expect(validator).not_to be_create_logs
+      end
+    end
   end
 end