From 10b0633c77a7a0139af60400f14985acd5bd16b4 Mon Sep 17 00:00:00 2001 From: Kat Date: Tue, 27 Jun 2023 15:24:51 +0100 Subject: [PATCH] Refactor organisation_relationship_policy --- .../organisation_relationship_policy.rb | 33 +++++++------------ 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/app/policies/organisation_relationship_policy.rb b/app/policies/organisation_relationship_policy.rb index 5f25ea6c8..7b539eb5e 100644 --- a/app/policies/organisation_relationship_policy.rb +++ b/app/policies/organisation_relationship_policy.rb @@ -6,27 +6,16 @@ class OrganisationRelationshipPolicy @organisation_relationship = organisation_relationship end - def add_stock_owner? - return true unless user.data_provider? - end - - def create_stock_owner? - return true unless user.data_provider? - end - - def remove_stock_owner? - return true unless user.data_provider? - end - - def add_managing_agent? - return true unless user.data_provider? - end - - def create_managing_agent? - return true unless user.data_provider? - end - - def remove_managing_agent? - return true unless user.data_provider? + %w[ + add_stock_owner? + create_stock_owner? + remove_stock_owner? + add_managing_agent? + create_managing_agent? + remove_managing_agent? + ].each do |method_name| + define_method method_name do + return true unless user.data_provider? + end end end