From 0fb1a73d2d7d09e5a2fd055599464b5f6b31e49b Mon Sep 17 00:00:00 2001 From: Rachael Booth Date: Fri, 24 Nov 2023 12:35:05 +0000 Subject: [PATCH] Try separating workflow call to job --- .github/workflows/review_pipeline.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/review_pipeline.yml b/.github/workflows/review_pipeline.yml index 7f95978c6..e70054088 100644 --- a/.github/workflows/review_pipeline.yml +++ b/.github/workflows/review_pipeline.yml @@ -30,14 +30,18 @@ jobs: repository: communitiesuk/submit-social-housing-lettings-and-sales-data-infrastructure ref: ReviewAppsDeploy - - name: Create review app infra - uses: communitiesuk/submit-social-housing-lettings-and-sales-data-infrastructure/.github/workflows/create_review_app_infra.yml@ReviewAppsDeploy - with: - key: ${{ github.event.pull_request.number }} + infra2: + name: Create review app infra + needs: [infra] + uses: communitiesuk/submit-social-housing-lettings-and-sales-data-infrastructure/.github/workflows/create_review_app_infra.yml@ReviewAppsDeploy + with: + key: ${{ github.event.pull_request.number }} + permissions: + id-token: write code: name: Deploy review app code - needs: [infra] + needs: [infra2] uses: ./.github/workflows/aws_deploy.yml with: aws_account_id: 837698168072