Browse Source

CLDC-3465 Do not display non persisted values in check errors page (#2484)

* Do not display non persisted values on check_errors page

* Remove govuk button styling from link

* Update warning message
pull/2472/head
kosiakkatrina 2 years ago committed by Kat
parent
commit
0faa846f72
  1. 1
      app/controllers/form_controller.rb
  2. 2
      app/views/check_errors/confirm_clear_all_answers.html.erb
  3. 2
      app/views/form/page.html.erb
  4. 4
      spec/requests/check_errors_controller_spec.rb

1
app/controllers/form_controller.rb

@ -418,6 +418,7 @@ private
responses_for_page = responses_for_page(@page)
@log.assign_attributes(responses_for_page)
@log.valid?
@log.reload
error_attributes = @log.errors.map(&:attribute)
@questions = @log.form.questions.select { |q| error_attributes.include?(q.id.to_sym) }
end

2
app/views/check_errors/confirm_clear_all_answers.html.erb

@ -9,7 +9,7 @@
</h1>
<p class="govuk-body">You've selected <%= @questions_to_clear.count %> answers to clear</p>
<%= govuk_warning_text(text: "You will not be able to undo this action") %>
<%= govuk_warning_text(text: "Dependent answers related to this question may also get cleared. You will not be able to undo this action") %>
<%= form_with model: @log, url: send("#{@log.model_name.param_key}_#{@page.id}_path", @log), method: "post", local: true do |f| %>
<% @related_question_ids.each do |id| %>

2
app/views/form/page.html.erb

@ -78,7 +78,7 @@
<% if all_questions_with_errors.count > 1 %>
<div class="govuk-button-group">
<%= f.govuk_submit "See all related answers", name: "check_errors", class: "govuk-body govuk-link submit-button-link" %>
<%= f.submit "See all related answers", name: "check_errors", class: "govuk-body govuk-link submit-button-link" %>
</div>
<% end %>

4
spec/requests/check_errors_controller_spec.rb

@ -52,13 +52,13 @@ RSpec.describe CheckErrorsController, type: :request do
end
before do
lettings_log.update!(needstype: 1, declaration: 1, ecstat1: 10, hhmemb: 2, net_income_known: 0, incfreq: 1, earnings: 1000)
lettings_log.update!(needstype: 1, declaration: 1, ecstat1: 10, hhmemb: 2, net_income_known: 0, incfreq: nil, earnings: nil)
sign_in user
post "/lettings-logs/#{lettings_log.id}/income-amount", params: params
end
it "displays correct clear links" do
expect(page).to have_selector("input[type=submit][value='Clear']", count: 3)
expect(page).to have_selector("input[type=submit][value='Clear']", count: 2)
expect(page).to have_button("Clear all")
end
end

Loading…
Cancel
Save